From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: avi@redhat.com
Subject: [Qemu-devel] [PATCH 10/11] memory: Fix old_portio vs non-zero offset.
Date: Wed, 10 Aug 2011 15:28:19 -0700 [thread overview]
Message-ID: <1313015300-23920-11-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1313015300-23920-1-git-send-email-rth@twiddle.net>
The legacy functions that we're wrapping expect that offset
to be included in the register. Indeed, they generally
expect the absolute address and then mask off the "high" bits.
The FDC is the first converted device with a non-zero offset.
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
memory.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/memory.c b/memory.c
index a1f118b..2c82cd3 100644
--- a/memory.c
+++ b/memory.c
@@ -367,7 +367,7 @@ static void memory_region_iorange_read(IORange *iorange,
*data = ((uint64_t)1 << (width * 8)) - 1;
if (mrp) {
- *data = mrp->read(mr->opaque, offset - mrp->offset);
+ *data = mrp->read(mr->opaque, offset);
}
return;
}
@@ -391,7 +391,7 @@ static void memory_region_iorange_write(IORange *iorange,
const MemoryRegionPortio *mrp = find_portio(mr, offset, width, true);
if (mrp) {
- mrp->write(mr->opaque, offset - mrp->offset, data);
+ mrp->write(mr->opaque, offset, data);
}
return;
}
--
1.7.6
next prev parent reply other threads:[~2011-08-10 22:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 22:28 [Qemu-devel] [PATCH 00/11] Memory API conversion for ISA Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 01/11] pci: add pci_address_space_io() Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 02/11] isa: Pass i/o address space to isa_bus_new Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 03/11] isa: add isa_register_ioport() Richard Henderson
2011-08-11 6:18 ` Avi Kivity
2011-08-10 22:28 ` [Qemu-devel] [PATCH 04/11] pc: Re-order pc_init1 to initialize the ISA bus before ISA devices Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 05/11] cs4231a: Convert to MemoryRegion Richard Henderson
2011-08-11 6:22 ` Avi Kivity
2011-08-11 6:27 ` Avi Kivity
2011-08-10 22:28 ` [Qemu-devel] [PATCH 06/11] i8254: " Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 07/11] i8259: " Richard Henderson
2011-08-28 15:25 ` Avi Kivity
2011-08-10 22:28 ` [Qemu-devel] [PATCH 08/11] pckbd: " Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 09/11] serial: Convert serial_isa_initfn " Richard Henderson
2011-08-10 22:28 ` Richard Henderson [this message]
2011-08-10 22:28 ` [Qemu-devel] [PATCH 11/11] fdc: Convert isabus_fdc_init1 " Richard Henderson
2011-08-11 7:48 ` [Qemu-devel] [PATCH 00/11] Memory API conversion for ISA Avi Kivity
2011-08-11 8:05 ` Edgar E. Iglesias
2011-08-11 8:20 ` Avi Kivity
2011-08-11 10:24 ` Edgar E. Iglesias
2011-08-11 11:19 ` Avi Kivity
2011-08-11 14:58 ` Richard Henderson
2011-08-11 15:16 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313015300-23920-11-git-send-email-rth@twiddle.net \
--to=rth@twiddle.net \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).