From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Alon Levy <alevy@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 2/3] qxl: unbreak after memory API conversion
Date: Thu, 11 Aug 2011 09:13:36 +0200 [thread overview]
Message-ID: <1313046817-5563-3-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1313046817-5563-1-git-send-email-kraxel@redhat.com>
From: Alon Levy <alevy@redhat.com>
Break is only noticable with newer spice-server library (0.8.2 release
or 0.9.0 and newer on master branch).
ioport_write's val was changed from uint32_t to uint64_t, this
broke two printfs. Use PRId64 instead of %d.
Signed-off-by: Alon Levy <alevy@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/qxl.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 7991e70..b34bccf 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1187,7 +1187,7 @@ async_common:
}
d->current_async = orig_io_port;
qemu_mutex_unlock(&d->async_lock);
- dprint(d, 2, "start async %d (%d)\n", io_port, val);
+ dprint(d, 2, "start async %d (%"PRId64")\n", io_port, val);
break;
default:
break;
@@ -1303,7 +1303,8 @@ async_common:
break;
}
case QXL_IO_FLUSH_SURFACES_ASYNC:
- dprint(d, 1, "QXL_IO_FLUSH_SURFACES_ASYNC (%d) (%s, s#=%d, res#=%d)\n",
+ dprint(d, 1, "QXL_IO_FLUSH_SURFACES_ASYNC"
+ " (%"PRId64") (%s, s#=%d, res#=%d)\n",
val, qxl_mode_to_string(d->mode), d->guest_surfaces.count,
d->num_free_res);
qxl_spice_flush_surfaces_async(d);
--
1.7.1
next prev parent reply other threads:[~2011-08-11 7:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 7:13 [Qemu-devel] [PULL] spice patch queue Gerd Hoffmann
2011-08-11 7:13 ` [Qemu-devel] [PATCH 1/3] qxl: allowing the command rings to be not empty when spice worker is stopped RHBZ #728984 Gerd Hoffmann
2011-08-11 7:13 ` Gerd Hoffmann [this message]
2011-08-11 7:13 ` [Qemu-devel] [PATCH 3/3] ui/spice-core: report compiled-version in info spice/query-spice Gerd Hoffmann
2011-08-12 7:00 ` [Qemu-devel] [PULL] spice patch queue Michael Tokarev
2011-08-12 7:56 ` Gerd Hoffmann
2011-08-12 13:04 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313046817-5563-3-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).