From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrPsX-0008D4-Gy for qemu-devel@nongnu.org; Thu, 11 Aug 2011 03:40:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QrPsW-0005hK-Jq for qemu-devel@nongnu.org; Thu, 11 Aug 2011 03:40:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrPsW-0005h9-4M for qemu-devel@nongnu.org; Thu, 11 Aug 2011 03:40:32 -0400 From: Avi Kivity Date: Thu, 11 Aug 2011 10:40:26 +0300 Message-Id: <1313048426-17273-3-git-send-email-avi@redhat.com> In-Reply-To: <1313048426-17273-1-git-send-email-avi@redhat.com> References: <1313048426-17273-1-git-send-email-avi@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] memory: crack wide ioport accesses into smaller ones when needed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori , Gerhard Wiesinger Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org The memory API supports cracking wide accesses into narrower ones when needed; but this was no implemented for the pio address space, causing lsi53c895a's IO BAR to malfunction. Fix by correctly cracking wide accesses when needed. Signed-off-by: Avi Kivity --- memory.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/memory.c b/memory.c index 3c18e70..81032b6 100644 --- a/memory.c +++ b/memory.c @@ -400,7 +400,11 @@ static void memory_region_iorange_read(IORange *iorange, } return; } - *data = mr->ops->read(mr->opaque, offset, width); + *data = 0; + access_with_adjusted_size(offset, data, width, + mr->ops->impl.min_access_size, + mr->ops->impl.max_access_size, + memory_region_read_accessor, mr); } static void memory_region_iorange_write(IORange *iorange, @@ -418,7 +422,10 @@ static void memory_region_iorange_write(IORange *iorange, } return; } - mr->ops->write(mr->opaque, offset, data, width); + access_with_adjusted_size(offset, &data, width, + mr->ops->impl.min_access_size, + mr->ops->impl.max_access_size, + memory_region_write_accessor, mr); } static const IORangeOps memory_region_iorange_ops = { -- 1.7.5.3