From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QroZH-0002bx-I8 for qemu-devel@nongnu.org; Fri, 12 Aug 2011 06:02:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QroZG-0002MF-GC for qemu-devel@nongnu.org; Fri, 12 Aug 2011 06:02:19 -0400 Received: from mail-qy0-f173.google.com ([209.85.216.173]:58123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QroZG-0002MB-Bk for qemu-devel@nongnu.org; Fri, 12 Aug 2011 06:02:18 -0400 Received: by qyk31 with SMTP id 31so271862qyk.4 for ; Fri, 12 Aug 2011 03:02:17 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Fri, 12 Aug 2011 11:59:41 +0200 Message-Id: <1313143181-7921-5-git-send-email-pbonzini@redhat.com> In-Reply-To: <1313143181-7921-1-git-send-email-pbonzini@redhat.com> References: <1313143181-7921-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v3 4/4] Partially revert "savevm: fix corruption in vmstate_subsection_load()." List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This reverts the additional check in commit eb60260d (but not the assertions). The new format does not require the check, and with the old format it traded one kind of bogus failure for a different kind of silent failure. Signed-off-by: Paolo Bonzini --- savevm.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/savevm.c b/savevm.c index a362ad7..2164edc 100644 --- a/savevm.c +++ b/savevm.c @@ -1699,10 +1699,6 @@ static int vmstate_subsection_load(QEMUFile *f, const VMStateDescription *vmsd, { const VMStateSubsection *sub = vmsd->subsections; - if (!sub || !sub->needed) { - return 0; - } - while (qemu_peek_byte(f) == QEMU_VM_SUBSECTION) { char idstr[256]; int ret; -- 1.7.6