qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] monitor: Fix "info mem" to print the last memory range
@ 2011-08-15  3:22 Austin Clements
  2011-08-21 18:27 ` Blue Swirl
  0 siblings, 1 reply; 2+ messages in thread
From: Austin Clements @ 2011-08-15  3:22 UTC (permalink / raw)
  To: qemu-devel; +Cc: Austin Clements, Markus Armbruster, Luiz Capitulino

"info mem" groups its output into contiguous ranges with identical
protection bits, but previously forgot to print the last range.

Signed-off-by: Austin Clements <amdragon@mit.edu>
---
 monitor.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/monitor.c b/monitor.c
index 6a4f8c2..f8ba0ef 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2258,6 +2258,8 @@ static void mem_info_32(Monitor *mon, CPUState *env)
             mem_print(mon, &start, &last_prot, end, prot);
         }
     }
+    /* Flush last range */
+    mem_print(mon, &start, &last_prot, (target_phys_addr_t)1 << 32, 0);
 }
 
 static void mem_info_pae32(Monitor *mon, CPUState *env)
@@ -2311,6 +2313,8 @@ static void mem_info_pae32(Monitor *mon, CPUState *env)
             mem_print(mon, &start, &last_prot, end, prot);
         }
     }
+    /* Flush last range */
+    mem_print(mon, &start, &last_prot, (target_phys_addr_t)1 << 32, 0);
 }
 
 
@@ -2385,6 +2389,8 @@ static void mem_info_64(Monitor *mon, CPUState *env)
             mem_print(mon, &start, &last_prot, end, prot);
         }
     }
+    /* Flush last range */
+    mem_print(mon, &start, &last_prot, (target_phys_addr_t)1 << 48, 0);
 }
 #endif
 
-- 
1.7.5.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] monitor: Fix "info mem" to print the last memory range
  2011-08-15  3:22 [Qemu-devel] [PATCH] monitor: Fix "info mem" to print the last memory range Austin Clements
@ 2011-08-21 18:27 ` Blue Swirl
  0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2011-08-21 18:27 UTC (permalink / raw)
  To: Austin Clements; +Cc: Luiz Capitulino, qemu-devel, Markus Armbruster

Thanks, applied.

On Mon, Aug 15, 2011 at 3:22 AM, Austin Clements <amdragon@mit.edu> wrote:
> "info mem" groups its output into contiguous ranges with identical
> protection bits, but previously forgot to print the last range.
>
> Signed-off-by: Austin Clements <amdragon@mit.edu>
> ---
>  monitor.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 6a4f8c2..f8ba0ef 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2258,6 +2258,8 @@ static void mem_info_32(Monitor *mon, CPUState *env)
>             mem_print(mon, &start, &last_prot, end, prot);
>         }
>     }
> +    /* Flush last range */
> +    mem_print(mon, &start, &last_prot, (target_phys_addr_t)1 << 32, 0);
>  }
>
>  static void mem_info_pae32(Monitor *mon, CPUState *env)
> @@ -2311,6 +2313,8 @@ static void mem_info_pae32(Monitor *mon, CPUState *env)
>             mem_print(mon, &start, &last_prot, end, prot);
>         }
>     }
> +    /* Flush last range */
> +    mem_print(mon, &start, &last_prot, (target_phys_addr_t)1 << 32, 0);
>  }
>
>
> @@ -2385,6 +2389,8 @@ static void mem_info_64(Monitor *mon, CPUState *env)
>             mem_print(mon, &start, &last_prot, end, prot);
>         }
>     }
> +    /* Flush last range */
> +    mem_print(mon, &start, &last_prot, (target_phys_addr_t)1 << 48, 0);
>  }
>  #endif
>
> --
> 1.7.5.4
>
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-21 18:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-15  3:22 [Qemu-devel] [PATCH] monitor: Fix "info mem" to print the last memory range Austin Clements
2011-08-21 18:27 ` Blue Swirl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).