qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: avi@redhat.com
Subject: [Qemu-devel] [PATCH 09/14] sb16: Convert to isa_register_old_portio_list.
Date: Tue, 16 Aug 2011 09:45:40 -0700	[thread overview]
Message-ID: <1313513145-5348-10-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1313513145-5348-1-git-send-email-rth@twiddle.net>

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 hw/sb16.c |   35 ++++++++++++++++-------------------
 1 files changed, 16 insertions(+), 19 deletions(-)

diff --git a/hw/sb16.c b/hw/sb16.c
index a76df1b..2a960b1 100644
--- a/hw/sb16.c
+++ b/hw/sb16.c
@@ -1341,12 +1341,24 @@ static const VMStateDescription vmstate_sb16 = {
     }
 };
 
+static const MemoryRegionPortio sb16_ioport_list[] = {
+    {  4, 1, 1, .write = mixer_write_indexb },
+    {  4, 1, 2, .write = mixer_write_indexw },
+    {  5, 1, 1, .read = mixer_read, .write = mixer_write_datab },
+    {  6, 1, 1, .read = dsp_read, .write = dsp_write },
+    PORTIO_END_OF_LIST(),
+    { 10, 1, 1, .read = dsp_read },
+    PORTIO_END_OF_LIST(),
+    { 12, 1, 1, .write = dsp_write },
+    { 12, 4, 1, .read = dsp_read },
+    PORTIO_END_OF_LIST(),
+    PORTIO_END_OF_LIST(),
+};
+
+
 static int sb16_initfn (ISADevice *dev)
 {
-    static const uint8_t dsp_write_ports[] = {0x6, 0xc};
-    static const uint8_t dsp_read_ports[] = {0x6, 0xa, 0xc, 0xd, 0xe, 0xf};
     SB16State *s;
-    int i;
 
     s = DO_UPCAST (SB16State, dev, dev);
 
@@ -1366,22 +1378,7 @@ static int sb16_initfn (ISADevice *dev)
         dolog ("warning: Could not create auxiliary timer\n");
     }
 
-    for (i = 0; i < ARRAY_SIZE (dsp_write_ports); i++) {
-        register_ioport_write (s->port + dsp_write_ports[i], 1, 1, dsp_write, s);
-        isa_init_ioport(dev, s->port + dsp_write_ports[i]);
-    }
-
-    for (i = 0; i < ARRAY_SIZE (dsp_read_ports); i++) {
-        register_ioport_read (s->port + dsp_read_ports[i], 1, 1, dsp_read, s);
-        isa_init_ioport(dev, s->port + dsp_read_ports[i]);
-    }
-
-    register_ioport_write (s->port + 0x4, 1, 1, mixer_write_indexb, s);
-    register_ioport_write (s->port + 0x4, 1, 2, mixer_write_indexw, s);
-    isa_init_ioport(dev, s->port + 0x4);
-    register_ioport_read (s->port + 0x5, 1, 1, mixer_read, s);
-    register_ioport_write (s->port + 0x5, 1, 1, mixer_write_datab, s);
-    isa_init_ioport(dev, s->port + 0x5);
+    isa_register_old_portio_list(dev, s->port, sb16_ioport_list, s, "sb16");
 
     DMA_register_channel (s->hdma, SB_read_DMA, s);
     DMA_register_channel (s->dma, SB_read_DMA, s);
-- 
1.7.6

  parent reply	other threads:[~2011-08-16 16:48 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-16 16:45 [Qemu-devel] [PATCH 00/14] Convert ISA I/O ports to Memory API Richard Henderson
2011-08-16 16:45 ` [Qemu-devel] [PATCH 01/14] isa: Tidy support code for isabus_get_fw_dev_path Richard Henderson
2011-08-16 16:45 ` [Qemu-devel] [PATCH 02/14] isa: Add isa_register_old_portio_list() Richard Henderson
2011-08-17 13:45   ` Avi Kivity
2011-08-17 13:50     ` Avi Kivity
2011-08-17 14:06       ` Richard Henderson
2011-08-17 14:09         ` Avi Kivity
2011-08-17 17:23     ` Blue Swirl
2011-08-17 19:07       ` Avi Kivity
2011-08-17 19:32         ` Blue Swirl
2011-08-17 19:41           ` Avi Kivity
2011-08-16 16:45 ` [Qemu-devel] [PATCH 03/14] fdc: Convert to isa_register_old_portio_list Richard Henderson
2011-08-16 16:45 ` [Qemu-devel] [PATCH 04/14] gus: " Richard Henderson
2011-08-18 17:02   ` malc
2011-08-16 16:45 ` [Qemu-devel] [PATCH 05/14] m48t59: Convert to isa_register_ioport Richard Henderson
2011-08-16 16:45 ` [Qemu-devel] [PATCH 06/14] rtc: " Richard Henderson
2011-08-16 16:45 ` [Qemu-devel] [PATCH 07/14] ne2000: " Richard Henderson
2011-08-16 16:45 ` [Qemu-devel] [PATCH 08/14] parallel: Convert to isa_register_old_portio_list Richard Henderson
2011-08-16 16:45 ` Richard Henderson [this message]
2011-08-16 16:45 ` [Qemu-devel] [PATCH 10/14] vga: " Richard Henderson
2011-08-16 16:45 ` [Qemu-devel] [PATCH 11/14] pc: Convert port92 to isa_register_ioport Richard Henderson
2011-08-17 13:54   ` Avi Kivity
2011-08-16 16:45 ` [Qemu-devel] [PATCH 12/14] vmport: Convert " Richard Henderson
2011-08-16 16:45 ` [Qemu-devel] [PATCH 13/14] ide: Convert to isa_register_old_portio_list Richard Henderson
2011-08-17 14:04   ` Avi Kivity
2011-08-17 14:11     ` Richard Henderson
2011-08-17 14:18       ` Avi Kivity
2011-08-17 14:13     ` Avi Kivity
2011-08-16 16:45 ` [Qemu-devel] [PATCH 14/14] isa: Remove isa_init_ioport_range and isa_init_ioport Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313513145-5348-10-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).