From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qtn2q-0006T4-Va for qemu-devel@nongnu.org; Wed, 17 Aug 2011 16:49:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qtn2p-0006kw-EI for qemu-devel@nongnu.org; Wed, 17 Aug 2011 16:49:00 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:61488) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qtn2p-0006dO-Az for qemu-devel@nongnu.org; Wed, 17 Aug 2011 16:48:59 -0400 Received: by mail-gy0-f173.google.com with SMTP id 12so1229686gyd.4 for ; Wed, 17 Aug 2011 13:48:58 -0700 (PDT) From: Bryce Lanham Date: Wed, 17 Aug 2011 15:46:32 -0500 Message-Id: <1313614076-28878-28-git-send-email-blanham@gmail.com> In-Reply-To: <1313614076-28878-1-git-send-email-blanham@gmail.com> References: <1313614076-28878-1-git-send-email-blanham@gmail.com> Subject: [Qemu-devel] [PATCH 027/111] m68k: add DBcc instruction. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Andreas Schwab From: Andreas Schwab Laurent Vivier writes: > + tmp = tcg_temp_new(); > + tcg_gen_ext16s_i32(tmp, reg); > + tcg_gen_addi_i32(tmp, tmp, -1); > + gen_partset_reg(OS_WORD, reg, tmp); > + tcg_gen_brcondi_i32(TCG_COND_EQ, tmp, 0, l1); The counter needs to be compared with -1, not 0. Andreas. --- target-m68k/translate.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 218210c..d4d2f44 100644 --- a/target-m68k/translate.c +++ b/target-m68k/translate.c @@ -939,7 +939,7 @@ DISAS_INSN(dbcc) tcg_gen_ext16s_i32(tmp, reg); tcg_gen_addi_i32(tmp, tmp, -1); gen_partset_reg(OS_WORD, reg, tmp); - tcg_gen_brcondi_i32(TCG_COND_EQ, tmp, 0, l1); + tcg_gen_brcondi_i32(TCG_COND_EQ, tmp, -1, l1); gen_jmp_tb(s, 1, base + offset); gen_set_label(l1); gen_jmp_tb(s, 0, s->pc); -- 1.7.2.3