From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36631) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QuiVK-0004qi-M9 for qemu-devel@nongnu.org; Sat, 20 Aug 2011 06:10:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QuiVJ-0003VZ-IW for qemu-devel@nongnu.org; Sat, 20 Aug 2011 06:10:14 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:38522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QuiVJ-0003VH-Cq for qemu-devel@nongnu.org; Sat, 20 Aug 2011 06:10:13 -0400 From: Stefan Weil Date: Sat, 20 Aug 2011 12:10:05 +0200 Message-Id: <1313835005-32480-1-git-send-email-weil@mail.berlios.de> In-Reply-To: <4E4F756C.3060907@mail.berlios.de> References: <4E4F756C.3060907@mail.berlios.de> Subject: [Qemu-devel] [PATCH] w32: Fix qemu_ftruncate64 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org SetFilePointer returns INVALID_SET_FILE_POINTER when it fails. In addition, GetLastError must be checked. The first call of SetFilePointer did not use INVALID_SET_FILE_POINTER, the second call used wrong error handling. Signed-off-by: Stefan Weil --- block/raw-win32.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/block/raw-win32.c b/block/raw-win32.c index e47cfe0..b7dd357 100644 --- a/block/raw-win32.c +++ b/block/raw-win32.c @@ -41,6 +41,7 @@ typedef struct BDRVRawState { int qemu_ftruncate64(int fd, int64_t length) { LARGE_INTEGER li; + DWORD dw; LONG high; HANDLE h; BOOL res; @@ -53,12 +54,15 @@ int qemu_ftruncate64(int fd, int64_t length) /* get current position, ftruncate do not change position */ li.HighPart = 0; li.LowPart = SetFilePointer (h, 0, &li.HighPart, FILE_CURRENT); - if (li.LowPart == 0xffffffffUL && GetLastError() != NO_ERROR) + if (li.LowPart == INVALID_SET_FILE_POINTER && GetLastError() != NO_ERROR) { return -1; + } high = length >> 32; - if (!SetFilePointer(h, (DWORD) length, &high, FILE_BEGIN)) + dw = SetFilePointer(h, (DWORD) length, &high, FILE_BEGIN); + if (dw == INVALID_SET_FILE_POINTER && GetLastError() != NO_ERROR) { return -1; + } res = SetEndOfFile(h); /* back to old position */ -- 1.7.2.5