From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52253) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvD6B-0002xU-5a for qemu-devel@nongnu.org; Sun, 21 Aug 2011 14:50:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QvD69-0000ze-Ua for qemu-devel@nongnu.org; Sun, 21 Aug 2011 14:50:19 -0400 Received: from dmz-mailsec-scanner-8.mit.edu ([18.7.68.37]:59244) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvD69-0000tt-QA for qemu-devel@nongnu.org; Sun, 21 Aug 2011 14:50:17 -0400 From: Austin Clements Date: Sun, 21 Aug 2011 14:49:45 -0400 Message-Id: <1313952585-32210-1-git-send-email-amdragon@mit.edu> In-Reply-To: <20110821184838.GP21339@mit.edu> References: <20110821184838.GP21339@mit.edu> Subject: [Qemu-devel] [PATCH] monitor: Prevent sign-extension of 32-bit addresses printed by info tlb List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Austin Clements , Markus Armbruster , Luiz Capitulino This is the same fix that was recently applied to info mem. Before this change, info tlb output looked like: ffffffffffffc000: 000000000fffc000 --------W ffffffffffffd000: 000000000fffd000 --------W ffffffffffffe000: 000000000fffe000 --------W fffffffffffff000: 000000000ffff000 --------W With this change, it looks like 00000000ffffc000: 000000000fffc000 --------W 00000000ffffd000: 000000000fffd000 --------W 00000000ffffe000: 000000000fffe000 --------W 00000000fffff000: 000000000ffff000 --------W Signed-off-by: Austin Clements --- monitor.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 249f845..001a42b 100644 --- a/monitor.c +++ b/monitor.c @@ -2199,7 +2199,7 @@ static void print_pte(Monitor *mon, target_phys_addr_t addr, static void tlb_info_32(Monitor *mon, CPUState *env) { - int l1, l2; + unsigned int l1, l2; uint32_t pgd, pde, pte; pgd = env->cr[3] & ~0xfff; @@ -2227,7 +2227,7 @@ static void tlb_info_32(Monitor *mon, CPUState *env) static void tlb_info_pae32(Monitor *mon, CPUState *env) { - int l1, l2, l3; + unsigned int l1, l2, l3; uint64_t pdpe, pde, pte; uint64_t pdp_addr, pd_addr, pt_addr; -- 1.7.5.4