From: Adam Litke <agl@us.ibm.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] qmp: add query-block-jobs
Date: Tue, 23 Aug 2011 11:28:24 -0500 [thread overview]
Message-ID: <1314116904.14814.1.camel@aglitke> (raw)
In-Reply-To: <1314104305-20523-5-git-send-email-stefanha@linux.vnet.ibm.com>
On Tue, 2011-08-23 at 13:58 +0100, Stefan Hajnoczi wrote:
> diff --git a/blockdev.c b/blockdev.c
> index 036b7eb..e9098f6 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -835,3 +835,13 @@ int do_block_job_cancel(Monitor *mon, const QDict *params, QObject **ret_data)
> qerror_report(QERR_DEVICE_NOT_ACTIVE, device);
> return -1;
> }
> +
> +void monitor_print_block_jobs(Monitor *mon, const QObject *data)
> +{
> + monitor_printf(mon, "No active jobs\n");
> +}
> +
> +void do_info_block_jobs(Monitor *mon, QObject **ret_data)
> +{
> + *ret_data = QOBJECT(qdict_new());
> +}
This should return an empty qlist, not a qdict.
--
Thanks,
Adam
next prev parent reply other threads:[~2011-08-23 16:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 12:58 [Qemu-devel] [PATCH 0/4] Image Streaming API Stefan Hajnoczi
2011-08-23 12:58 ` [Qemu-devel] [PATCH 1/4] qmp: add block_stream command Stefan Hajnoczi
2011-08-23 16:33 ` Adam Litke
2011-08-30 9:43 ` Stefan Hajnoczi
2011-08-23 12:58 ` [Qemu-devel] [PATCH 2/4] qmp: add block_job_set_speed command Stefan Hajnoczi
2011-08-23 12:58 ` [Qemu-devel] [PATCH 3/4] qmp: add block_job_cancel command Stefan Hajnoczi
2011-08-23 12:58 ` [Qemu-devel] [PATCH 4/4] qmp: add query-block-jobs Stefan Hajnoczi
2011-08-23 16:28 ` Adam Litke [this message]
2011-08-29 19:16 ` [Qemu-devel] [PATCH 0/4] Image Streaming API Anthony Liguori
2011-08-29 19:45 ` Luiz Capitulino
2011-08-30 3:19 ` Zhi Yong Wu
2011-08-30 9:28 ` Stefan Hajnoczi
2011-08-30 13:32 ` Adam Litke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314116904.14814.1.camel@aglitke \
--to=agl@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).