From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qvtqa-0001fG-7A for qemu-devel@nongnu.org; Tue, 23 Aug 2011 12:29:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QvtqZ-0007ew-5f for qemu-devel@nongnu.org; Tue, 23 Aug 2011 12:29:04 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:52642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvtqZ-0007cT-1g for qemu-devel@nongnu.org; Tue, 23 Aug 2011 12:29:03 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e6.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p7NG4Q8Y008385 for ; Tue, 23 Aug 2011 12:04:26 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p7NGSWvW208980 for ; Tue, 23 Aug 2011 12:28:33 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p7NGSSii030391 for ; Tue, 23 Aug 2011 12:28:29 -0400 From: Adam Litke In-Reply-To: <1314104305-20523-5-git-send-email-stefanha@linux.vnet.ibm.com> References: <1314104305-20523-1-git-send-email-stefanha@linux.vnet.ibm.com> <1314104305-20523-5-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 23 Aug 2011 11:28:24 -0500 Message-ID: <1314116904.14814.1.camel@aglitke> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] qmp: add query-block-jobs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Anthony Liguori , qemu-devel@nongnu.org On Tue, 2011-08-23 at 13:58 +0100, Stefan Hajnoczi wrote: > diff --git a/blockdev.c b/blockdev.c > index 036b7eb..e9098f6 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -835,3 +835,13 @@ int do_block_job_cancel(Monitor *mon, const QDict *params, QObject **ret_data) > qerror_report(QERR_DEVICE_NOT_ACTIVE, device); > return -1; > } > + > +void monitor_print_block_jobs(Monitor *mon, const QObject *data) > +{ > + monitor_printf(mon, "No active jobs\n"); > +} > + > +void do_info_block_jobs(Monitor *mon, QObject **ret_data) > +{ > + *ret_data = QOBJECT(qdict_new()); > +} This should return an empty qlist, not a qdict. -- Thanks, Adam