From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: avi@redhat.com
Subject: [Qemu-devel] [PATCH 05/16] fdc: Convert to isa_register_portio_list.
Date: Tue, 23 Aug 2011 17:13:44 -0700 [thread overview]
Message-ID: <1314144835-29098-6-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1314144835-29098-1-git-send-email-rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
hw/fdc.c | 34 ++++------------------------------
1 files changed, 4 insertions(+), 30 deletions(-)
diff --git a/hw/fdc.c b/hw/fdc.c
index c3ae956..b83c045 100644
--- a/hw/fdc.c
+++ b/hw/fdc.c
@@ -425,7 +425,6 @@ typedef struct FDCtrlSysBus {
typedef struct FDCtrlISABus {
ISADevice busdev;
- MemoryRegion io_0, io_7;
struct FDCtrl state;
int32_t bootindexA;
int32_t bootindexB;
@@ -1882,32 +1881,10 @@ static int fdctrl_init_common(FDCtrl *fdctrl)
return fdctrl_connect_drives(fdctrl);
}
-static uint32_t fdctrl_read_port_7(void *opaque, uint32_t reg)
-{
- return fdctrl_read(opaque, reg + 7);
-}
-
-static void fdctrl_write_port_7(void *opaque, uint32_t reg, uint32_t value)
-{
- fdctrl_write(opaque, reg + 7, value);
-}
-
-static const MemoryRegionPortio fdc_portio_0[] = {
+static const MemoryRegionPortio fdc_portio_list[] = {
{ 1, 5, 1, .read = fdctrl_read, .write = fdctrl_write },
- PORTIO_END_OF_LIST()
-};
-
-static const MemoryRegionPortio fdc_portio_7[] = {
- { 0, 1, 1, .read = fdctrl_read_port_7, .write = fdctrl_write_port_7 },
- PORTIO_END_OF_LIST()
-};
-
-static const MemoryRegionOps fdc_ioport_0_ops = {
- .old_portio = fdc_portio_0
-};
-
-static const MemoryRegionOps fdc_ioport_7_ops = {
- .old_portio = fdc_portio_7
+ { 7, 1, 1, .read = fdctrl_read, .write = fdctrl_write },
+ PORTIO_END_OF_LIST(),
};
static int isabus_fdc_init1(ISADevice *dev)
@@ -1919,10 +1896,7 @@ static int isabus_fdc_init1(ISADevice *dev)
int dma_chann = 2;
int ret;
- memory_region_init_io(&isa->io_0, &fdc_ioport_0_ops, fdctrl, "fdc", 6);
- memory_region_init_io(&isa->io_7, &fdc_ioport_7_ops, fdctrl, "fdc", 1);
- isa_register_ioport(dev, &isa->io_0, iobase);
- isa_register_ioport(dev, &isa->io_7, iobase + 7);
+ isa_register_portio_list(dev, iobase, fdc_portio_list, fdctrl, "fdc");
isa_init_irq(&isa->busdev, &fdctrl->irq, isairq);
fdctrl->dma_chann = dma_chann;
--
1.7.4.4
next prev parent reply other threads:[~2011-08-24 0:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 0:13 [Qemu-devel] [PATCH 00/16] isa_register_portio_list, v2 Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 01/16] fixup: merge with last sm501 patch Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 02/16] fixup: merge with last arm_sysctl patch Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 03/16] isa: Tidy support code for isabus_get_fw_dev_path Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 04/16] isa: Add isa_register_portio_list() Richard Henderson
2011-08-24 0:13 ` Richard Henderson [this message]
2011-08-24 0:13 ` [Qemu-devel] [PATCH 06/16] gus: Convert to isa_register_portio_list Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 07/16] m48t59: Convert to isa_register_ioport Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 08/16] rtc: " Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 09/16] ne2000: " Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 10/16] parallel: Convert to isa_register_portio_list Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 11/16] sb16: " Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 12/16] vga: " Richard Henderson
2011-09-18 13:45 ` Avi Kivity
2011-09-18 14:16 ` Richard Henderson
2011-09-18 14:27 ` Avi Kivity
2011-09-18 14:56 ` Avi Kivity
2011-09-18 15:15 ` Richard Henderson
2011-09-18 15:19 ` Avi Kivity
2011-08-24 0:13 ` [Qemu-devel] [PATCH 13/16] pc: Convert port92 to isa_register_ioport Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 14/16] vmport: Convert " Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 15/16] ide: Convert to isa_register_portio_list Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 16/16] isa: Remove isa_init_ioport_range and isa_init_ioport Richard Henderson
2011-08-24 9:18 ` [Qemu-devel] [PATCH 00/16] isa_register_portio_list, v2 Avi Kivity
2011-08-24 9:35 ` malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314144835-29098-6-git-send-email-rth@twiddle.net \
--to=rth@twiddle.net \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).