From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: avi@redhat.com
Subject: [Qemu-devel] [PATCH 08/16] rtc: Convert to isa_register_ioport.
Date: Tue, 23 Aug 2011 17:13:47 -0700 [thread overview]
Message-ID: <1314144835-29098-9-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1314144835-29098-1-git-send-email-rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
hw/mc146818rtc.c | 15 ++++++++++++---
1 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index feb3b25..2aaca2f 100644
--- a/hw/mc146818rtc.c
+++ b/hw/mc146818rtc.c
@@ -81,6 +81,7 @@
typedef struct RTCState {
ISADevice dev;
+ MemoryRegion io;
uint8_t cmos_data[128];
uint8_t cmos_index;
struct tm current_tm;
@@ -604,6 +605,15 @@ static void rtc_reset(void *opaque)
#endif
}
+static const MemoryRegionPortio cmos_portio[] = {
+ {0, 2, 1, .read = cmos_ioport_read, .write = cmos_ioport_write },
+ PORTIO_END_OF_LIST(),
+};
+
+static const MemoryRegionOps cmos_ops = {
+ .old_portio = cmos_portio
+};
+
static int rtc_initfn(ISADevice *dev)
{
RTCState *s = DO_UPCAST(RTCState, dev, dev);
@@ -632,9 +642,8 @@ static int rtc_initfn(ISADevice *dev)
qemu_get_clock_ns(rtc_clock) + (get_ticks_per_sec() * 99) / 100;
qemu_mod_timer(s->second_timer2, s->next_second_time);
- register_ioport_write(base, 2, 1, cmos_ioport_write, s);
- register_ioport_read(base, 2, 1, cmos_ioport_read, s);
- isa_init_ioport_range(dev, base, 2);
+ memory_region_init_io(&s->io, &cmos_ops, s, "rtc", 2);
+ isa_register_ioport(dev, &s->io, base);
qdev_set_legacy_instance_id(&dev->qdev, base, 2);
qemu_register_reset(rtc_reset, s);
--
1.7.4.4
next prev parent reply other threads:[~2011-08-24 0:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 0:13 [Qemu-devel] [PATCH 00/16] isa_register_portio_list, v2 Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 01/16] fixup: merge with last sm501 patch Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 02/16] fixup: merge with last arm_sysctl patch Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 03/16] isa: Tidy support code for isabus_get_fw_dev_path Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 04/16] isa: Add isa_register_portio_list() Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 05/16] fdc: Convert to isa_register_portio_list Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 06/16] gus: " Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 07/16] m48t59: Convert to isa_register_ioport Richard Henderson
2011-08-24 0:13 ` Richard Henderson [this message]
2011-08-24 0:13 ` [Qemu-devel] [PATCH 09/16] ne2000: " Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 10/16] parallel: Convert to isa_register_portio_list Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 11/16] sb16: " Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 12/16] vga: " Richard Henderson
2011-09-18 13:45 ` Avi Kivity
2011-09-18 14:16 ` Richard Henderson
2011-09-18 14:27 ` Avi Kivity
2011-09-18 14:56 ` Avi Kivity
2011-09-18 15:15 ` Richard Henderson
2011-09-18 15:19 ` Avi Kivity
2011-08-24 0:13 ` [Qemu-devel] [PATCH 13/16] pc: Convert port92 to isa_register_ioport Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 14/16] vmport: Convert " Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 15/16] ide: Convert to isa_register_portio_list Richard Henderson
2011-08-24 0:13 ` [Qemu-devel] [PATCH 16/16] isa: Remove isa_init_ioport_range and isa_init_ioport Richard Henderson
2011-08-24 9:18 ` [Qemu-devel] [PATCH 00/16] isa_register_portio_list, v2 Avi Kivity
2011-08-24 9:35 ` malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314144835-29098-9-git-send-email-rth@twiddle.net \
--to=rth@twiddle.net \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).