From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 12/22] piix_pci: wrap memory update in a transaction
Date: Wed, 24 Aug 2011 16:40:49 +0300 [thread overview]
Message-ID: <1314193259-27092-13-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1314193259-27092-1-git-send-email-avi@redhat.com>
The code will remap all PAMs, even if just one is updated, resulting
in reduced performance. Wrap in a transaction to detect that those
other PAMs have not changed.
Signed-off-by: Avi Kivity <avi@redhat.com>
---
hw/piix_pci.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index f892994..8f6ea42 100644
--- a/hw/piix_pci.c
+++ b/hw/piix_pci.c
@@ -142,6 +142,7 @@ static void i440fx_update_memory_mappings(PCII440FXState *d)
int i, r;
uint32_t smram;
+ memory_region_transaction_begin();
update_pam(d, 0xf0000, 0x100000, (d->dev.config[I440FX_PAM] >> 4) & 3,
&d->pam_regions[0]);
for(i = 0; i < 12; i++) {
@@ -162,6 +163,7 @@ static void i440fx_update_memory_mappings(PCII440FXState *d)
d->smram_enabled = false;
}
}
+ memory_region_transaction_commit();
}
static void i440fx_set_smm(int val, void *arg)
--
1.7.5.3
next prev parent reply other threads:[~2011-08-24 13:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 13:40 [Qemu-devel] [PATCH v2 00/22] Memory API conversions, batch 5 Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 01/22] stellaris_enet: convert to memory API Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 02/22] sysbus: add helpers to add and delete memory regions to the system bus Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 03/22] pci_host: convert conf index and data ports to memory API Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 04/22] ReadWriteHandler: remove Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 05/22] an5206: convert to memory API Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 06/22] armv7m: " Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 07/22] axis_dev88: convert to memory API (RAM only) Avi Kivity
2011-08-24 19:04 ` Edgar E. Iglesias
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 08/22] sysbus: add sysbus_add_memory_overlap() Avi Kivity
2011-08-24 17:00 ` Richard Henderson
2011-08-24 17:11 ` Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 09/22] integratorcp: convert to memory API (RAM/flash only) Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 10/22] leon3: convert to memory API Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 11/22] cirrus: wrap memory update in a transaction Avi Kivity
2011-08-24 13:40 ` Avi Kivity [this message]
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 13/22] Makefile.hw: allow hw/ files to include glib headers Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 14/22] pflash_cfi01/pflash_cfi02: convert to memory API Avi Kivity
2011-08-25 11:37 ` Jan Kiszka
2011-08-25 11:48 ` Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 15/22] dummy_m68k: " Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 16/22] g364fb: " Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 17/22] lm32_boards: " Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 18/22] mainstone: " Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 19/22] mcf5208: " Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 20/22] milkymist-minimac2: " Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 21/22] milkymist-softusb: " Avi Kivity
2011-08-24 13:40 ` [Qemu-devel] [PATCH v2 22/22] milkymist: " Avi Kivity
2011-08-24 17:10 ` [Qemu-devel] [PATCH v2 00/22] Memory API conversions, batch 5 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314193259-27092-13-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).