From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 14/19] i8254: Convert to MemoryRegion
Date: Thu, 25 Aug 2011 11:09:13 +0300 [thread overview]
Message-ID: <1314259758-5198-15-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1314259758-5198-1-git-send-email-avi@redhat.com>
From: Richard Henderson <rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Avi Kivity <avi@redhat.com>
---
hw/i8254.c | 16 +++++++++++++---
1 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/hw/i8254.c b/hw/i8254.c
index a9ca9f6..12571ef 100644
--- a/hw/i8254.c
+++ b/hw/i8254.c
@@ -55,6 +55,7 @@ typedef struct PITChannelState {
typedef struct PITState {
ISADevice dev;
+ MemoryRegion ioports;
uint32_t irq;
uint32_t iobase;
PITChannelState channels[3];
@@ -506,6 +507,16 @@ void hpet_pit_enable(void)
pit_load_count(s, 0);
}
+static const MemoryRegionPortio pit_portio[] = {
+ { 0, 4, 1, .write = pit_ioport_write },
+ { 0, 3, 1, .read = pit_ioport_read },
+ PORTIO_END_OF_LIST()
+};
+
+static const MemoryRegionOps pit_ioport_ops = {
+ .old_portio = pit_portio
+};
+
static int pit_initfn(ISADevice *dev)
{
PITState *pit = DO_UPCAST(PITState, dev, dev);
@@ -516,9 +527,8 @@ static int pit_initfn(ISADevice *dev)
s->irq_timer = qemu_new_timer_ns(vm_clock, pit_irq_timer, s);
s->irq = isa_get_irq(pit->irq);
- register_ioport_write(pit->iobase, 4, 1, pit_ioport_write, pit);
- register_ioport_read(pit->iobase, 3, 1, pit_ioport_read, pit);
- isa_init_ioport(dev, pit->iobase);
+ memory_region_init_io(&pit->ioports, &pit_ioport_ops, pit, "pit", 4);
+ isa_register_ioport(dev, &pit->ioports, pit->iobase);
qdev_set_legacy_instance_id(&dev->qdev, pit->iobase, 2);
--
1.7.5.3
next prev parent reply other threads:[~2011-08-25 8:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 8:08 [Qemu-devel] [PATCH 00/19] Memory API conversions: batch 6 Avi Kivity
2011-08-25 8:09 ` [Qemu-devel] [PATCH 01/19] mips_fulong2e: convert to memory API Avi Kivity
2011-08-25 8:09 ` [Qemu-devel] [PATCH 02/19] mips_jazz: " Avi Kivity
2011-08-25 8:09 ` [Qemu-devel] [PATCH 03/19] mips_malta: " Avi Kivity
2011-08-25 8:09 ` [Qemu-devel] [PATCH 04/19] mips_mipssim: " Avi Kivity
2011-08-25 8:09 ` [Qemu-devel] [PATCH 05/19] mips_r4k: " Avi Kivity
2011-08-25 8:09 ` [Qemu-devel] [PATCH 06/19] musicpal: " Avi Kivity
2011-08-25 8:09 ` [Qemu-devel] [PATCH 07/19] omap1: convert to memory API (part I) Avi Kivity
2011-08-25 8:09 ` [Qemu-devel] [PATCH 08/19] omap1: convert to memory API (part II) Avi Kivity
2011-08-25 8:09 ` [Qemu-devel] [PATCH 09/19] pci: add pci_address_space_io() Avi Kivity
2011-08-25 8:09 ` [Qemu-devel] [PATCH 10/19] isa: Pass i/o address space to isa_bus_new Avi Kivity
2011-08-25 8:09 ` [Qemu-devel] [PATCH 11/19] isa: add isa_register_ioport() Avi Kivity
2011-08-25 8:09 ` [Qemu-devel] [PATCH 12/19] pc: Re-order pc_init1 to initialize the ISA bus before ISA devices Avi Kivity
2011-08-25 8:09 ` [Qemu-devel] [PATCH 13/19] cs4231a: Convert to MemoryRegion Avi Kivity
2011-08-25 8:09 ` Avi Kivity [this message]
2011-08-25 8:09 ` [Qemu-devel] [PATCH 15/19] i8259: " Avi Kivity
2011-08-25 8:09 ` [Qemu-devel] [PATCH 16/19] pckbd: " Avi Kivity
2011-08-25 8:09 ` [Qemu-devel] [PATCH 17/19] serial: Convert serial_isa_initfn " Avi Kivity
2011-08-25 8:09 ` [Qemu-devel] [PATCH 18/19] fdc: Convert isabus_fdc_init1 " Avi Kivity
2011-08-25 8:09 ` [Qemu-devel] [PATCH 19/19] pci: simplify memory region registration Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314259758-5198-15-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).