From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: [Qemu-devel] [PATCH 08/17] omap_gpmc: Fix handling of FIFOTHRESHOLDSTATUS bit
Date: Thu, 25 Aug 2011 21:05:02 +0100 [thread overview]
Message-ID: <1314302711-20498-9-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1314302711-20498-1-git-send-email-peter.maydell@linaro.org>
The OMAP3 TRM is inconsistent about whether the GPMC FIFOTHRESHOLDSTATUS
bit should be set when FIFOPOINTER > FIFOTHRESHOLD or when it is >=
FIFOTHRESHOLD. Apparently the underlying functional spec from which
the TRM was created states that the behaviour is ">=", and this also
makes more conceptual sense.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/omap_gpmc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/omap_gpmc.c b/hw/omap_gpmc.c
index b728397..9da8491 100644
--- a/hw/omap_gpmc.c
+++ b/hw/omap_gpmc.c
@@ -222,7 +222,7 @@ static uint64_t omap_gpmc_read(void *opaque, target_phys_addr_t addr,
return s->prefcontrol;
case 0x1f0: /* GPMC_PREFETCH_STATUS */
return (s->preffifo << 24) |
- ((s->preffifo >
+ ((s->preffifo >=
((s->prefconfig[0] >> 8) & 0x7f) ? 1 : 0) << 16) |
s->prefcount;
--
1.7.1
next prev parent reply other threads:[~2011-08-25 20:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 20:04 [Qemu-devel] [PATCH 00/17] onenand, omap_gpmc fixes, features Peter Maydell
2011-08-25 20:04 ` [Qemu-devel] [PATCH 01/17] hw/sysbus: Add sysbus_mmio_get_region() Peter Maydell
2011-08-25 20:04 ` [Qemu-devel] [PATCH 02/17] hw/onenand: Qdevify Peter Maydell
2011-08-27 17:38 ` Edgar E. Iglesias
2011-08-28 13:21 ` Peter Maydell
2011-08-28 14:16 ` Edgar E. Iglesias
2011-08-25 20:04 ` [Qemu-devel] [PATCH 03/17] hw/onenand: Minor spacing fixes Peter Maydell
2011-08-25 20:04 ` [Qemu-devel] [PATCH 04/17] omap_gpmc: Clean up omap_gpmc_attach MemoryRegion conversion Peter Maydell
2011-08-25 20:04 ` [Qemu-devel] [PATCH 05/17] omap_gpmc: Refactor omap_gpmc_cs_map and omap_gpmc_cs_unmap Peter Maydell
2011-08-25 20:05 ` [Qemu-devel] [PATCH 06/17] omap_gpmc: GPMC_IRQSTATUS is write-one-to-clear Peter Maydell
2011-08-25 20:05 ` [Qemu-devel] [PATCH 07/17] omap_gpmc: Wire up the GPMC IRQ correctly Peter Maydell
2011-08-25 20:05 ` Peter Maydell [this message]
2011-08-25 20:05 ` [Qemu-devel] [PATCH 09/17] omap_gpmc: Take omap_mpu_state* in omap_gpmc_init Peter Maydell
2011-08-25 20:05 ` [Qemu-devel] [PATCH 10/17] omap_gpmc: Calculate revision from OMAP model Peter Maydell
2011-08-25 20:05 ` [Qemu-devel] [PATCH 11/17] omap_gpmc: Reindent misindented switch statements Peter Maydell
2011-08-25 20:05 ` [Qemu-devel] [PATCH 12/17] omap_gpmc: Support NAND devices Peter Maydell
2011-08-25 20:05 ` [Qemu-devel] [PATCH 13/17] hw/omap.h: Add OMAP 3630 to omap_mpu_model enumeration Peter Maydell
2011-08-25 20:05 ` [Qemu-devel] [PATCH 14/17] omap_gpmc: Accept a zero mask field on omap3630 Peter Maydell
2011-08-25 20:05 ` [Qemu-devel] [PATCH 15/17] omap_gpmc: Pull prefetch engine data into sub-struct Peter Maydell
2011-08-25 20:05 ` [Qemu-devel] [PATCH 16/17] omap: Wire up the DMA request line to the GPMC Peter Maydell
2011-08-25 20:05 ` [Qemu-devel] [PATCH 17/17] omap_gpmc: Implement prefetch engine Peter Maydell
2011-08-27 2:30 ` [Qemu-devel] [PATCH 00/17] onenand, omap_gpmc fixes, features Edgar E. Iglesias
2011-08-27 12:19 ` Peter Maydell
2011-08-28 8:38 ` Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314302711-20498-9-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).