From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyJ17-0006lf-7m for qemu-devel@nongnu.org; Tue, 30 Aug 2011 03:45:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QyJ15-0003B5-PZ for qemu-devel@nongnu.org; Tue, 30 Aug 2011 03:45:53 -0400 Received: from mail-qy0-f173.google.com ([209.85.216.173]:59283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyJ15-0003At-HR for qemu-devel@nongnu.org; Tue, 30 Aug 2011 03:45:51 -0400 Received: by qyk31 with SMTP id 31so2497511qyk.4 for ; Tue, 30 Aug 2011 00:45:50 -0700 (PDT) From: Frediano Ziglio Date: Tue, 30 Aug 2011 09:46:11 +0200 Message-Id: <1314690371-9138-1-git-send-email-freddy77@gmail.com> Subject: [Qemu-devel] [PATCH] linux aio: some comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kwolf@redhat.com Cc: qemu-devel@nongnu.org, Frediano Ziglio Add some notes about Linux AIO explaining why we don't use AIO in some situations. Signed-off-by: Frediano Ziglio --- block/raw-posix.c | 4 ++++ linux-aio.c | 1 + 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index c5c9944..bcf50b2 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -236,6 +236,10 @@ static int raw_open_common(BlockDriverState *bs, const char *filename, } #ifdef CONFIG_LINUX_AIO + /* + * Currently Linux do AIO only for files opened with O_DIRECT + * specified so check NOCACHE flag too + */ if ((bdrv_flags & (BDRV_O_NOCACHE|BDRV_O_NATIVE_AIO)) == (BDRV_O_NOCACHE|BDRV_O_NATIVE_AIO)) { diff --git a/linux-aio.c b/linux-aio.c index 5fd3932..5265a02 100644 --- a/linux-aio.c +++ b/linux-aio.c @@ -181,6 +181,7 @@ BlockDriverAIOCB *laio_submit(BlockDriverState *bs, void *aio_ctx, int fd, case QEMU_AIO_READ: io_prep_preadv(iocbs, fd, qiov->iov, qiov->niov, offset); break; + /* Currently Linux kernel does not support other operations */ default: fprintf(stderr, "%s: invalid AIO request type 0x%x.\n", __func__, type); -- 1.7.1