From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qyk2I-0002k1-2R for qemu-devel@nongnu.org; Wed, 31 Aug 2011 08:36:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qyk2C-0008RZ-TJ for qemu-devel@nongnu.org; Wed, 31 Aug 2011 08:36:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qyk2C-0008RU-KJ for qemu-devel@nongnu.org; Wed, 31 Aug 2011 08:36:48 -0400 From: Yonit Halperin Date: Wed, 31 Aug 2011 15:37:33 +0300 Message-Id: <1314794254-11624-1-git-send-email-yhalperi@redhat.com> Subject: [Qemu-devel] [PATCH v2 1/2] qxl: send interrupt after migration in case ram->int_pending != 0, RHBZ #732949 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Yonit Halperin , alevy@redhat.com, kraxel@redhat.com, spice-devel@freedesktop.org if qxl_send_events was called from spice server context, and then migration had completed before a call to pipe_read, the target guest qxl driver didn't get the interrupt. In addition, qxl_send_events ignored further interrupts of the same kind, since ram->int_pending was set. As a result, the guest driver was stacked or very slow (when the waiting for the interrupt was with timeout). --- hw/qxl.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index b34bccf..c7edc60 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1362,7 +1362,6 @@ static void pipe_read(void *opaque) qxl_set_irq(d); } -/* called from spice server thread context only */ static void qxl_send_events(PCIQXLDevice *d, uint32_t events) { uint32_t old_pending; @@ -1463,7 +1462,13 @@ static void qxl_vm_change_state_handler(void *opaque, int running, int reason) PCIQXLDevice *qxl = opaque; qemu_spice_vm_change_state_handler(&qxl->ssd, running, reason); - if (!running && qxl->mode == QXL_MODE_NATIVE) { + if (running) { + /* + * if qxl_send_events was called from spice server context before + * migration ended, qxl_set_irq for these events might not have been called + */ + qxl_set_irq(qxl); + } else if (qxl->mode == QXL_MODE_NATIVE) { /* dirty all vram (which holds surfaces) and devram (primary surface) * to make sure they are saved */ /* FIXME #1: should go out during "live" stage */ -- 1.7.4.4