From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Riku Voipio" <riku.voipio@iki.fi>,
"Juha Riihimäki" <juha.riihimaki@nokia.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
patches@linaro.org
Subject: [Qemu-devel] [PATCH 1/3] usb: Remove leading underscores from __musb_irq_max
Date: Wed, 31 Aug 2011 21:49:39 +0100 [thread overview]
Message-ID: <1314823781-304-2-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1314823781-304-1-git-send-email-peter.maydell@linaro.org>
Identifiers with double leading underscore are reserved, so rename
__musb_irq_max so we don't encroach on reserved namespace.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/tusb6010.c | 6 +++---
hw/usb.h | 3 ++-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/hw/tusb6010.c b/hw/tusb6010.c
index de6ffc6..78814f1 100644
--- a/hw/tusb6010.c
+++ b/hw/tusb6010.c
@@ -785,9 +785,9 @@ static int tusb6010_init(SysBusDevice *dev)
sysbus_init_mmio_region(dev, &s->iomem[0]);
sysbus_init_mmio_region(dev, &s->iomem[1]);
sysbus_init_irq(dev, &s->irq);
- qdev_init_gpio_in(&dev->qdev, tusb6010_irq, __musb_irq_max + 1);
- musb_irqs = g_new0(qemu_irq, __musb_irq_max);
- for (i = 0; i < __musb_irq_max; i++) {
+ qdev_init_gpio_in(&dev->qdev, tusb6010_irq, musb_irq_max + 1);
+ musb_irqs = g_new0(qemu_irq, musb_irq_max);
+ for (i = 0; i < musb_irq_max; i++) {
musb_irqs[i] = qdev_get_gpio_in(&dev->qdev, i + 1);
}
s->musb = musb_init(musb_irqs);
diff --git a/hw/usb.h b/hw/usb.h
index d784448..e7ce395 100644
--- a/hw/usb.h
+++ b/hw/usb.h
@@ -337,7 +337,8 @@ enum musb_irq_source_e {
musb_irq_tx,
musb_set_vbus,
musb_set_session,
- __musb_irq_max,
+ /* Add new interrupts here */
+ musb_irq_max, /* total number of interrupts defined */
};
typedef struct MUSBState MUSBState;
--
1.7.1
next prev parent reply other threads:[~2011-08-31 20:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 20:49 [Qemu-devel] [PATCH 0/3] usb-musb: make qdev-aware Peter Maydell
2011-08-31 20:49 ` Peter Maydell [this message]
2011-08-31 20:49 ` [Qemu-devel] [PATCH 2/3] usb-musb: Take a DeviceState* in init function Peter Maydell
2011-08-31 20:49 ` [Qemu-devel] [PATCH 3/3] usb-musb: Add reset function Peter Maydell
2011-09-01 14:38 ` [Qemu-devel] [PATCH 0/3] usb-musb: make qdev-aware Gerd Hoffmann
2011-09-01 15:57 ` Peter Maydell
2011-09-02 7:03 ` Juha.Riihimaki
2011-09-02 7:50 ` Gerd Hoffmann
2011-09-02 8:00 ` Riku Voipio
2011-09-02 8:42 ` Marcin Juszkiewicz
2011-09-02 14:23 ` Gerd Hoffmann
2011-09-02 8:55 ` Peter Maydell
2011-09-02 10:27 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314823781-304-2-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=juha.riihimaki@nokia.com \
--cc=kraxel@redhat.com \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).