From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 16/18] usb: Remove leading underscores from __musb_irq_max
Date: Fri, 2 Sep 2011 11:56:45 +0200 [thread overview]
Message-ID: <1314957407-29508-17-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1314957407-29508-1-git-send-email-kraxel@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Identifiers with double leading underscore are reserved, so rename
__musb_irq_max so we don't encroach on reserved namespace.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/tusb6010.c | 6 +++---
hw/usb.h | 3 ++-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/hw/tusb6010.c b/hw/tusb6010.c
index de6ffc6..78814f1 100644
--- a/hw/tusb6010.c
+++ b/hw/tusb6010.c
@@ -785,9 +785,9 @@ static int tusb6010_init(SysBusDevice *dev)
sysbus_init_mmio_region(dev, &s->iomem[0]);
sysbus_init_mmio_region(dev, &s->iomem[1]);
sysbus_init_irq(dev, &s->irq);
- qdev_init_gpio_in(&dev->qdev, tusb6010_irq, __musb_irq_max + 1);
- musb_irqs = g_new0(qemu_irq, __musb_irq_max);
- for (i = 0; i < __musb_irq_max; i++) {
+ qdev_init_gpio_in(&dev->qdev, tusb6010_irq, musb_irq_max + 1);
+ musb_irqs = g_new0(qemu_irq, musb_irq_max);
+ for (i = 0; i < musb_irq_max; i++) {
musb_irqs[i] = qdev_get_gpio_in(&dev->qdev, i + 1);
}
s->musb = musb_init(musb_irqs);
diff --git a/hw/usb.h b/hw/usb.h
index 73479d6..e251e61 100644
--- a/hw/usb.h
+++ b/hw/usb.h
@@ -338,7 +338,8 @@ enum musb_irq_source_e {
musb_irq_tx,
musb_set_vbus,
musb_set_session,
- __musb_irq_max,
+ /* Add new interrupts here */
+ musb_irq_max, /* total number of interrupts defined */
};
typedef struct MUSBState MUSBState;
--
1.7.1
next prev parent reply other threads:[~2011-09-02 9:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 9:56 [Qemu-devel] [PULL] usb patch queue Gerd Hoffmann
2011-09-02 9:56 ` [Qemu-devel] [PATCH 01/18] usb-host: start tracing support Gerd Hoffmann
2011-09-02 9:56 ` [Qemu-devel] [PATCH 02/18] usb-host: reapurb error report fix Gerd Hoffmann
2011-09-02 9:56 ` [Qemu-devel] [PATCH 03/18] usb-host: fix halted endpoints Gerd Hoffmann
2011-09-02 9:56 ` [Qemu-devel] [PATCH 04/18] usb-host: limit open retries Gerd Hoffmann
2011-09-02 9:56 ` [Qemu-devel] [PATCH 05/18] usb-host: fix configuration tracking Gerd Hoffmann
2011-09-02 9:56 ` [Qemu-devel] [PATCH 06/18] usb-host: claim port Gerd Hoffmann
2011-09-02 9:56 ` [Qemu-devel] [PATCH 07/18] usb-host: endpoint table fixup Gerd Hoffmann
2011-09-02 9:56 ` [Qemu-devel] [PATCH 08/18] usb-ehci: handle siTDs Gerd Hoffmann
2011-09-02 9:56 ` [Qemu-devel] [PATCH 09/18] usb-host: constify port Gerd Hoffmann
2011-09-02 9:56 ` [Qemu-devel] [PATCH 10/18] usb-host: parse port in /proc/bus/usb/devices scan Gerd Hoffmann
2011-09-02 9:56 ` [Qemu-devel] [PATCH 11/18] usb: fix use after free Gerd Hoffmann
2011-09-02 9:56 ` [Qemu-devel] [PATCH 12/18] usb-ccid: switch to USBDesc* Gerd Hoffmann
2011-09-02 9:56 ` [Qemu-devel] [PATCH 13/18] usb-ccid: remote wakeup support Gerd Hoffmann
2011-09-02 9:56 ` [Qemu-devel] [PATCH 14/18] usb: claim port at device initialization time Gerd Hoffmann
2011-09-02 9:56 ` [Qemu-devel] [PATCH 15/18] usb-host: tag as unmigratable Gerd Hoffmann
2011-09-02 9:56 ` Gerd Hoffmann [this message]
2011-09-02 9:56 ` [Qemu-devel] [PATCH 17/18] usb-musb: Take a DeviceState* in init function Gerd Hoffmann
2011-09-02 9:56 ` [Qemu-devel] [PATCH 18/18] usb-musb: Add reset function Gerd Hoffmann
2011-09-07 8:41 ` [Qemu-devel] [PULL] usb patch queue Gerd Hoffmann
2011-09-08 14:23 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314957407-29508-17-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).