qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 04/18] usb-host: limit open retries
Date: Fri,  2 Sep 2011 11:56:33 +0200	[thread overview]
Message-ID: <1314957407-29508-5-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1314957407-29508-1-git-send-email-kraxel@redhat.com>

Limit the number of times qemu tries to open host devices to three.
Reset error counter when the device goes away, after un-plugging and
re-plugging the device qemu will try again three times.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 usb-linux.c |   13 ++++++++++++-
 1 files changed, 12 insertions(+), 1 deletions(-)

diff --git a/usb-linux.c b/usb-linux.c
index 344af22..36d25d7 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -132,6 +132,7 @@ typedef struct USBHostDevice {
     int addr;
     char port[MAX_PORTLEN];
     struct USBAutoFilter match;
+    int seen, errcount;
 
     QTAILQ_ENTRY(USBHostDevice) next;
 } USBHostDevice;
@@ -1769,6 +1770,10 @@ static int usb_host_auto_scan(void *opaque, int bus_num, int addr, char *port,
             continue;
         }
         /* We got a match */
+        s->seen++;
+        if (s->errcount >= 3) {
+            return 0;
+        }
 
         /* Already attached ? */
         if (s->fd != -1) {
@@ -1776,7 +1781,9 @@ static int usb_host_auto_scan(void *opaque, int bus_num, int addr, char *port,
         }
         DPRINTF("husb: auto open: bus_num %d addr %d\n", bus_num, addr);
 
-        usb_host_open(s, bus_num, addr, port, product_name, speed);
+        if (usb_host_open(s, bus_num, addr, port, product_name, speed) < 0) {
+            s->errcount++;
+        }
         break;
     }
 
@@ -1794,6 +1801,10 @@ static void usb_host_auto_check(void *unused)
         if (s->fd == -1) {
             unconnected++;
         }
+        if (s->seen == 0) {
+            s->errcount = 0;
+        }
+        s->seen = 0;
     }
 
     if (unconnected == 0) {
-- 
1.7.1

  parent reply	other threads:[~2011-09-02  9:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-02  9:56 [Qemu-devel] [PULL] usb patch queue Gerd Hoffmann
2011-09-02  9:56 ` [Qemu-devel] [PATCH 01/18] usb-host: start tracing support Gerd Hoffmann
2011-09-02  9:56 ` [Qemu-devel] [PATCH 02/18] usb-host: reapurb error report fix Gerd Hoffmann
2011-09-02  9:56 ` [Qemu-devel] [PATCH 03/18] usb-host: fix halted endpoints Gerd Hoffmann
2011-09-02  9:56 ` Gerd Hoffmann [this message]
2011-09-02  9:56 ` [Qemu-devel] [PATCH 05/18] usb-host: fix configuration tracking Gerd Hoffmann
2011-09-02  9:56 ` [Qemu-devel] [PATCH 06/18] usb-host: claim port Gerd Hoffmann
2011-09-02  9:56 ` [Qemu-devel] [PATCH 07/18] usb-host: endpoint table fixup Gerd Hoffmann
2011-09-02  9:56 ` [Qemu-devel] [PATCH 08/18] usb-ehci: handle siTDs Gerd Hoffmann
2011-09-02  9:56 ` [Qemu-devel] [PATCH 09/18] usb-host: constify port Gerd Hoffmann
2011-09-02  9:56 ` [Qemu-devel] [PATCH 10/18] usb-host: parse port in /proc/bus/usb/devices scan Gerd Hoffmann
2011-09-02  9:56 ` [Qemu-devel] [PATCH 11/18] usb: fix use after free Gerd Hoffmann
2011-09-02  9:56 ` [Qemu-devel] [PATCH 12/18] usb-ccid: switch to USBDesc* Gerd Hoffmann
2011-09-02  9:56 ` [Qemu-devel] [PATCH 13/18] usb-ccid: remote wakeup support Gerd Hoffmann
2011-09-02  9:56 ` [Qemu-devel] [PATCH 14/18] usb: claim port at device initialization time Gerd Hoffmann
2011-09-02  9:56 ` [Qemu-devel] [PATCH 15/18] usb-host: tag as unmigratable Gerd Hoffmann
2011-09-02  9:56 ` [Qemu-devel] [PATCH 16/18] usb: Remove leading underscores from __musb_irq_max Gerd Hoffmann
2011-09-02  9:56 ` [Qemu-devel] [PATCH 17/18] usb-musb: Take a DeviceState* in init function Gerd Hoffmann
2011-09-02  9:56 ` [Qemu-devel] [PATCH 18/18] usb-musb: Add reset function Gerd Hoffmann
2011-09-07  8:41 ` [Qemu-devel] [PULL] usb patch queue Gerd Hoffmann
2011-09-08 14:23 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314957407-29508-5-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).