From: "Daniel P. Berrange" <dan@berrange.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrange" <dan@berrange.com>
Subject: [Qemu-devel] [PATCH v2] Display logical disk size in 'info block' output
Date: Fri, 2 Sep 2011 17:38:10 +0100 [thread overview]
Message-ID: <1314981490-24200-1-git-send-email-dan@berrange.com> (raw)
From: "Daniel P. Berrange" <dan@berrange.com>
To aid in knowing whether a 'block_resize' was succesful, display
the logical disk size in bytes, in the 'info block' output
In v2:
- Replace sectors with bytes
Signed-off-by: Daniel P. Berrange <dan@berrange.com>
---
block.c | 6 ++++--
qmp-commands.hx | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 03a21d8..03102ad 100644
--- a/block.c
+++ b/block.c
@@ -1844,6 +1844,7 @@ static void bdrv_print_dict(QObject *obj, void *opaque)
monitor_printf(mon, " file=");
monitor_print_filename(mon, qdict_get_str(qdict, "file"));
+ monitor_printf(mon, " length=%" PRId64, qdict_get_int(qdict, "length"));
if (qdict_haskey(qdict, "backing_file")) {
monitor_printf(mon, " backing_file=");
monitor_print_filename(mon, qdict_get_str(qdict, "backing_file"));
@@ -1884,10 +1885,11 @@ void bdrv_info(Monitor *mon, QObject **ret_data)
QDict *bs_dict = qobject_to_qdict(bs_obj);
obj = qobject_from_jsonf("{ 'file': %s, 'ro': %i, 'drv': %s, "
- "'encrypted': %i }",
+ "'encrypted': %i, 'length': %" PRId64 " }",
bs->filename, bs->read_only,
bs->drv->format_name,
- bdrv_is_encrypted(bs));
+ bdrv_is_encrypted(bs),
+ bdrv_getlength(bs));
if (bs->backing_file[0] != '\0') {
QDict *qdict = qobject_to_qdict(obj);
qdict_put(qdict, "backing_file",
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 27cc66e..d185504 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -1134,6 +1134,7 @@ Each json-object contain the following:
- "inserted": only present if the device is inserted, it is a json-object
containing the following:
- "file": device file name (json-string)
+ - "length": logical disk size in bytes (json-int)
- "ro": true if read-only, false otherwise (json-bool)
- "drv": driver format name (json-string)
- Possible values: "blkdebug", "bochs", "cloop", "cow", "dmg",
--
1.7.6
next reply other threads:[~2011-09-02 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 16:38 Daniel P. Berrange [this message]
2011-09-03 14:01 ` [Qemu-devel] [PATCH v2] Display logical disk size in 'info block' output Stefan Hajnoczi
2011-09-05 12:44 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314981490-24200-1-git-send-email-dan@berrange.com \
--to=dan@berrange.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).