From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: minyard@acm.org, QEMU Developers <qemu-devel@nongnu.org>
Cc: "Corey Minyard" <cminyard@mvista.com>,
"Fam Zheng" <famz@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] qdev: Add a no default uuid property
Date: Tue, 2 Jul 2019 11:00:38 +0200 [thread overview]
Message-ID: <1314c0c8-304b-b8b3-ae7a-84384b9dc282@redhat.com> (raw)
In-Reply-To: <20190701183100.7849-2-minyard@acm.org>
Cc'ing Markus & Eric.
On 7/1/19 8:30 PM, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> This is for IPMI, which will behave differently if the UUID is
> not set.
>
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> Cc: Fam Zheng <famz@redhat.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> include/hw/qdev-properties.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
> index 1eae5ab056..7fd887af84 100644
> --- a/include/hw/qdev-properties.h
> +++ b/include/hw/qdev-properties.h
> @@ -237,6 +237,13 @@ extern const PropertyInfo qdev_prop_pcie_link_width;
> .set_default = true, \
> }
>
> +#define DEFINE_PROP_UUID_NODEFAULT(_name, _state, _field) { \
> + .name = (_name), \
> + .info = &qdev_prop_uuid, \
> + .offset = offsetof(_state, _field) \
> + + type_check(QemuUUID, typeof_field(_state, _field)), \
> + }
> +
> #define DEFINE_PROP_END_OF_LIST() \
> {}
>
>
next prev parent reply other threads:[~2019-07-02 9:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 18:30 [Qemu-devel] [PATCH v2 0/2] Add a UUID device property to IPMI minyard
2019-07-01 18:30 ` [Qemu-devel] [PATCH v2 1/2] qdev: Add a no default uuid property minyard
2019-07-02 9:00 ` Philippe Mathieu-Daudé [this message]
2019-07-01 18:31 ` [Qemu-devel] [PATCH v2 2/2] ipmi: Add a UUID device property minyard
2019-07-02 9:07 ` Philippe Mathieu-Daudé
2019-07-03 14:26 ` Daniel P. Berrangé
2019-07-06 22:57 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314c0c8-304b-b8b3-ae7a-84384b9dc282@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=cminyard@mvista.com \
--cc=famz@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=minyard@acm.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).