From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43582) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0FaB-0005fi-Bb for qemu-devel@nongnu.org; Sun, 04 Sep 2011 12:30:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R0FaA-0004fY-1L for qemu-devel@nongnu.org; Sun, 04 Sep 2011 12:30:07 -0400 From: Stefan Weil Date: Sun, 4 Sep 2011 18:30:02 +0200 Message-Id: <1315153802-24346-1-git-send-email-weil@mail.berlios.de> Subject: [Qemu-devel] [PATCH] configure: Avoid duplicate flags when calling compile_prog List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Developers Cc: qemu-trivial@nongnu.org This patch removes redundant shell code and cleans it a little bit. Shell macro compile_prog takes two arguments: local_cflags and local ldflags. $QEMU_CFLAGS is added automatically to the cflags, so there is no need to pass it as an argument. It is also unnecessary to pass -Werror twice. $flag is a compiler warning option, so it should be in local_cflags instead of local_ldflags. Signed-off-by: Stefan Weil --- configure | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index c3044c7..d261fdd 100755 --- a/configure +++ b/configure @@ -1071,7 +1071,7 @@ cat > $TMPC << EOF int main(void) { return 0; } EOF for flag in $gcc_flags; do - if compile_prog "-Werror $QEMU_CFLAGS" "-Werror $flag" ; then + if compile_prog "$flag -Werror" "" ; then QEMU_CFLAGS="$QEMU_CFLAGS $flag" fi done -- 1.7.0.4