qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 02/31] qcow2: Properly initialise QcowL2Meta
Date: Tue,  6 Sep 2011 17:39:17 +0200	[thread overview]
Message-ID: <1315323586-23840-3-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1315323586-23840-1-git-send-email-kwolf@redhat.com>

Dependency list pointers filled with random garbage from the stack aren't a
good idea.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/qcow2.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/block/qcow2.c b/block/qcow2.c
index b725d68..f26f7b6 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -526,13 +526,14 @@ static int qcow2_co_writev(BlockDriverState *bs,
     int n_end;
     int ret;
     int cur_nr_sectors; /* number of sectors in current iteration */
-    QCowL2Meta l2meta;
     uint64_t cluster_offset;
     QEMUIOVector hd_qiov;
     uint64_t bytes_done = 0;
     uint8_t *cluster_data = NULL;
+    QCowL2Meta l2meta = {
+        .nb_clusters = 0,
+    };
 
-    l2meta.nb_clusters = 0;
     qemu_co_queue_init(&l2meta.dependent_requests);
 
     qemu_iovec_init(&hd_qiov, qiov->niov);
-- 
1.7.6

  parent reply	other threads:[~2011-09-06 15:37 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-06 15:39 [Qemu-devel] [PULL 00/31] Block patches Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 01/31] linux aio: some comments Kevin Wolf
2011-09-06 15:39 ` Kevin Wolf [this message]
2011-09-06 15:39 ` [Qemu-devel] [PATCH 03/31] qcow2: Fix error cases to run depedent requests Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 04/31] async: Allow nested qemu_bh_poll calls Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 05/31] block: Attach non-qdev devices as well Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 06/31] block: Generalize change_cb() to BlockDevOps Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 07/31] block: Split change_cb() into change_media_cb(), resize_cb() Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 08/31] ide: Update command code definitions as per ACS-2 Table B.2 Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 09/31] ide: Clean up case label indentation in ide_exec_cmd() Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 10/31] ide: Give vmstate structs internal linkage where possible Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 11/31] block/raw: Fix to forward method bdrv_media_changed() Kevin Wolf
2011-09-07 19:25   ` Blue Swirl
2011-09-08  7:40     ` Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 12/31] block: Leave tracking media change to device models Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 13/31] fdc: Make media change detection more robust Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 14/31] block: Clean up bdrv_flush_all() Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 15/31] savevm: Include writable devices with removable media Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 16/31] xen: Clean up pci_piix3_xen_ide_unplug()'s test for "not a CD" Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 17/31] spitz tosa: Simplify "drive is suitable for microdrive" test Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 18/31] block: Declare qemu_blockalign() in block.h, not block_int.h Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 19/31] VMDK: enable twoGbMaxExtentFlat Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 20/31] VMDK: add twoGbMaxExtentSparse support Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 21/31] VMDK: separate vmdk_read_extent/vmdk_write_extent Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 22/31] VMDK: Opening compressed extent Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 23/31] VMDK: read/write " Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 24/31] VMDK: creating streamOptimized subformat Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 25/31] VMDK: bugfix, open Haiku vmdk image Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 26/31] VMDK: bugfix, opening vSphere 4 exported image Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 27/31] scsi: execute SYNCHRONIZE_CACHE asynchronously Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 28/31] scsi: fix accounting of writes Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 29/31] scsi: refine constants for READ CAPACITY 16 Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 30/31] scsi: fill in additional sense length correctly Kevin Wolf
2011-09-06 15:39 ` [Qemu-devel] [PATCH 31/31] scsi: improve MODE SENSE emulation Kevin Wolf
2011-09-08 14:24 ` [Qemu-devel] [PULL 00/31] Block patches Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1315323586-23840-3-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).