* [Qemu-devel] [PULL 0/2]: QMP queue @ 2011-09-06 16:44 Luiz Capitulino 2011-09-06 16:44 ` [Qemu-devel] [PATCH 1/2] configure: Copy test data to build directory Luiz Capitulino ` (2 more replies) 0 siblings, 3 replies; 4+ messages in thread From: Luiz Capitulino @ 2011-09-06 16:44 UTC (permalink / raw) To: aliguori; +Cc: qemu-devel Anthony, The following patches have been sent to the list and look good to me. I've also tested them. The changes (since 344eecf6995f4a0ad1d887cec922f6806f91a3f8) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Jan Kiszka (1): Fix qjson test of solidus encoding Luiz Capitulino (1): configure: Copy test data to build directory check-qjson.c | 3 ++- configure | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH 1/2] configure: Copy test data to build directory 2011-09-06 16:44 [Qemu-devel] [PULL 0/2]: QMP queue Luiz Capitulino @ 2011-09-06 16:44 ` Luiz Capitulino 2011-09-06 16:44 ` [Qemu-devel] [PATCH 2/2] Fix qjson test of solidus encoding Luiz Capitulino 2011-09-08 14:24 ` [Qemu-devel] [PULL 0/2]: QMP queue Anthony Liguori 2 siblings, 0 replies; 4+ messages in thread From: Luiz Capitulino @ 2011-09-06 16:44 UTC (permalink / raw) To: aliguori; +Cc: qemu-devel The QDict unit-tests (check-qdict) will fail when ran on a different build directory. That's, it only works when ran on the source dir. This happens because its data file (qdict-test-data.txt) is not copied to the build dir. Fix it. Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com> --- configure | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index c3044c7..fe3147b 100755 --- a/configure +++ b/configure @@ -3614,7 +3614,7 @@ DIRS="$DIRS roms/seabios roms/vgabios" DIRS="$DIRS fsdev ui" DIRS="$DIRS qapi" DIRS="$DIRS qga trace" -FILES="Makefile tests/Makefile" +FILES="Makefile tests/Makefile qdict-test-data.txt" FILES="$FILES tests/cris/Makefile tests/cris/.gdbinit" FILES="$FILES pc-bios/optionrom/Makefile pc-bios/keymaps" FILES="$FILES pc-bios/spapr-rtas/Makefile" -- 1.7.7.rc0.72.g4b5ea ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH 2/2] Fix qjson test of solidus encoding 2011-09-06 16:44 [Qemu-devel] [PULL 0/2]: QMP queue Luiz Capitulino 2011-09-06 16:44 ` [Qemu-devel] [PATCH 1/2] configure: Copy test data to build directory Luiz Capitulino @ 2011-09-06 16:44 ` Luiz Capitulino 2011-09-08 14:24 ` [Qemu-devel] [PULL 0/2]: QMP queue Anthony Liguori 2 siblings, 0 replies; 4+ messages in thread From: Luiz Capitulino @ 2011-09-06 16:44 UTC (permalink / raw) To: aliguori; +Cc: Jan Kiszka, qemu-devel From: Jan Kiszka <jan.kiszka@siemens.com> "\/" is supposed to be decoded as "/", but there is no need to encode "/" via escape. Fix the existing test and add a second one expressing this. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Acked-by: Michael Roth <mdroth@linux.vnet.ibm.com> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com> --- check-qjson.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/check-qjson.c b/check-qjson.c index 64fcdcb..36d4ac2 100644 --- a/check-qjson.c +++ b/check-qjson.c @@ -33,7 +33,8 @@ START_TEST(escaped_string) { "\"\\n\"", "\n" }, { "\"\\r\"", "\r" }, { "\"\\t\"", "\t" }, - { "\"\\/\"", "\\/" }, + { "\"/\"", "/" }, + { "\"\\/\"", "/", .skip = 1 }, { "\"\\\\\"", "\\" }, { "\"\\\"\"", "\"" }, { "\"hello world \\\"embedded string\\\"\"", -- 1.7.7.rc0.72.g4b5ea ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PULL 0/2]: QMP queue 2011-09-06 16:44 [Qemu-devel] [PULL 0/2]: QMP queue Luiz Capitulino 2011-09-06 16:44 ` [Qemu-devel] [PATCH 1/2] configure: Copy test data to build directory Luiz Capitulino 2011-09-06 16:44 ` [Qemu-devel] [PATCH 2/2] Fix qjson test of solidus encoding Luiz Capitulino @ 2011-09-08 14:24 ` Anthony Liguori 2 siblings, 0 replies; 4+ messages in thread From: Anthony Liguori @ 2011-09-08 14:24 UTC (permalink / raw) To: Luiz Capitulino; +Cc: qemu-devel On 09/06/2011 11:44 AM, Luiz Capitulino wrote: > Anthony, > > The following patches have been sent to the list and look good to me. I've > also tested them. Pulled. Thanks. Regards, Anthony Liguori > > The changes (since 344eecf6995f4a0ad1d887cec922f6806f91a3f8) are available > in the following repository: > > git://repo.or.cz/qemu/qmp-unstable.git queue/qmp > > Jan Kiszka (1): > Fix qjson test of solidus encoding > > Luiz Capitulino (1): > configure: Copy test data to build directory > > check-qjson.c | 3 ++- > configure | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-09-08 14:25 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-09-06 16:44 [Qemu-devel] [PULL 0/2]: QMP queue Luiz Capitulino 2011-09-06 16:44 ` [Qemu-devel] [PATCH 1/2] configure: Copy test data to build directory Luiz Capitulino 2011-09-06 16:44 ` [Qemu-devel] [PATCH 2/2] Fix qjson test of solidus encoding Luiz Capitulino 2011-09-08 14:24 ` [Qemu-devel] [PULL 0/2]: QMP queue Anthony Liguori
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).