qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: zwu.kernel@gmail.com, Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>,
	stefanha@linux.vnet.ibm.com, agl@us.ibm.com
Subject: [Qemu-devel] [PATCH v1] domain_conf: add the support for disk I/O throttle setting
Date: Wed,  7 Sep 2011 16:59:55 +0800	[thread overview]
Message-ID: <1315385995-23283-1-git-send-email-wuzhy@linux.vnet.ibm.com> (raw)

The first patch is only used to see if it is suitable for exteeding blkiotune to implement disk I/O throttling.

As you have known, when blkiotune is issued without options, it will display current tuning parameters; If we exceed it, without options, what should it display? both info will? or should one new option be added to separately display them?

Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
---
 src/conf/domain_conf.c |   18 ++++++++++++++++++
 src/conf/domain_conf.h |   11 +++++++++++
 2 files changed, 29 insertions(+), 0 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index cce9955..7dd350a 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -9065,6 +9065,24 @@ virDomainDiskDefFormat(virBufferPtr buf,
     virBufferAsprintf(buf, "      <target dev='%s' bus='%s'/>\n",
                       def->dst, bus);
 
+    /*disk I/O throttling*/
+    if (def->blkio.blkiothrottle) {
+        virBufferAsprintf(&buf, "  <blkiothrottle>\n");
+        virBufferAsprintf(&buf, "    <bps>%llu</bps>\n",
+                          def->blkiothrottle.bps);
+        virBufferAsprintf(&buf, "    <bps_rd>%llu</bps_rd>\n",
+                          def->blkiothrottle.bps_rd);
+        virBufferAsprintf(&buf, "    <bps_wr>%llu</bps_wr>\n",
+                          def->blkiothrottle.bps_wr);
+        virBufferAsprintf(&buf, "    <iops>%llu</iops>\n",
+                          def->blkiothrottle.iops);
+        virBufferAsprintf(&buf, "    <iops_rd>%llu</iops_rd>\n",
+                          def->blkiothrottle.iops_rd);
+        virBufferAsprintf(&buf, "    <iops_wr>%llu</iops_wr>\n",
+                          def->blkiothrottle.iops_wr);
+        virBufferAsprintf(&buf, "  </blkiothrottle>\n");
+    }
+
     if (def->bootIndex)
         virBufferAsprintf(buf, "      <boot order='%d'/>\n", def->bootIndex);
     if (def->readonly)
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index e218a30..5902377 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -258,6 +258,17 @@ struct _virDomainDiskDef {
     virDomainDiskHostDefPtr hosts;
     char *driverName;
     char *driverType;
+
+    /*disk I/O throttling*/
+    struct {
+        unsigned long long bps;
+        unsigned long long bps_rd;
+        unsigned long long bps_wr;
+        unsigned long long iops;
+        unsigned long long iops_rd;
+        unsigned long long iops_wr;
+    } blkiothrottle;
+
     char *serial;
     int cachemode;
     int error_policy;
-- 
1.7.6

             reply	other threads:[~2011-09-07  9:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-07  8:59 Zhi Yong Wu [this message]
2011-09-07  9:09 ` [Qemu-devel] sorry, pls ignore, it is not correct.Re: [PATCH v1] domain_conf: add the support for disk I/O throttle setting Zhi Yong Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1315385995-23283-1-git-send-email-wuzhy@linux.vnet.ibm.com \
    --to=wuzhy@linux.vnet.ibm.com \
    --cc=agl@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=zwu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).