From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1LPq-0005Y1-6M for qemu-devel@nongnu.org; Wed, 07 Sep 2011 12:56:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R1LPo-00029M-Vl for qemu-devel@nongnu.org; Wed, 07 Sep 2011 12:55:58 -0400 Received: from cobra.newdream.net ([66.33.216.30]:36806) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1LPo-000297-Rg for qemu-devel@nongnu.org; Wed, 07 Sep 2011 12:55:56 -0400 From: Sage Weil Date: Wed, 7 Sep 2011 09:28:05 -0700 Message-Id: <1315412886-21092-2-git-send-email-sage@newdream.net> In-Reply-To: <1315412886-21092-1-git-send-email-sage@newdream.net> References: <1315412886-21092-1-git-send-email-sage@newdream.net> Subject: [Qemu-devel] [PATCH 2/3] rbd: clean up, fix style List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, kwolf@redhat.com Cc: Sage Weil , ceph-devel@vger.kernel.org No assignment in condition. Remove duplicate ret > 0 check. Signed-off-by: Sage Weil --- block/rbd.c | 17 ++++++++--------- 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 6135fc1..2763092 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -391,15 +391,14 @@ static void qemu_rbd_aio_event_reader(void *opaque) char *p = (char *)&s->event_rcb; /* now read the rcb pointer that was sent from a non qemu thread */ - if ((ret = read(s->fds[RBD_FD_READ], p + s->event_reader_pos, - sizeof(s->event_rcb) - s->event_reader_pos)) > 0) { - if (ret > 0) { - s->event_reader_pos += ret; - if (s->event_reader_pos == sizeof(s->event_rcb)) { - s->event_reader_pos = 0; - qemu_rbd_complete_aio(s->event_rcb); - s->qemu_aio_count--; - } + ret = read(s->fds[RBD_FD_READ], p + s->event_reader_pos, + sizeof(s->event_rcb) - s->event_reader_pos); + if (ret > 0) { + s->event_reader_pos += ret; + if (s->event_reader_pos == sizeof(s->event_rcb)) { + s->event_reader_pos = 0; + qemu_rbd_complete_aio(s->event_rcb); + s->qemu_aio_count--; } } } while (ret < 0 && errno == EINTR); -- 1.7.2.5