From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R322y-0000TW-6J for qemu-devel@nongnu.org; Mon, 12 Sep 2011 04:39:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R31xE-00054F-Jk for qemu-devel@nongnu.org; Mon, 12 Sep 2011 04:33:44 -0400 Received: from mnementh.archaic.org.uk ([81.2.115.146]:36151) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R31xE-00052s-2V for qemu-devel@nongnu.org; Mon, 12 Sep 2011 04:33:24 -0400 From: Peter Maydell Date: Mon, 12 Sep 2011 09:33:15 +0100 Message-Id: <1315816395-27304-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH] hw/omap_gpmc: Don't try to map CS0 twice on reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , Avi Kivity , patches@linaro.org Remove a spurious second map of the OMAP GPMC CS0 region on reset. This fixes an assertion failure when we try to add the region to its container when it was already added. (The old code did not complain about mismatched map/unmap calls, but the new MemoryRegion implementation does.) Signed-off-by: Peter Maydell --- hw/omap_gpmc.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/omap_gpmc.c b/hw/omap_gpmc.c index 922d622..673dddd 100644 --- a/hw/omap_gpmc.c +++ b/hw/omap_gpmc.c @@ -135,7 +135,6 @@ void omap_gpmc_reset(struct omap_gpmc_s *s) s->cs_file[i].config[6] & 0x1f, /* MASKADDR */ (s->cs_file[i].config[6] >> 8 & 0xf)); /* BASEADDR */ } - omap_gpmc_cs_map(s->cs_file, 0, 0xf); s->ecc_cs = 0; s->ecc_ptr = 0; s->ecc_cfg = 0x3fcff000; -- 1.7.1