From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3SCW-00049q-MT for qemu-devel@nongnu.org; Tue, 13 Sep 2011 08:35:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R3SCQ-0008RW-JP for qemu-devel@nongnu.org; Tue, 13 Sep 2011 08:34:56 -0400 Received: from mtagate3.uk.ibm.com ([194.196.100.163]:49961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3SCQ-0008Pw-8v for qemu-devel@nongnu.org; Tue, 13 Sep 2011 08:34:50 -0400 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate3.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p8DCYhci026292 for ; Tue, 13 Sep 2011 12:34:43 GMT Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p8DCYgT92482270 for ; Tue, 13 Sep 2011 13:34:43 +0100 Received: from d06av04.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p8DCYg6E032220 for ; Tue, 13 Sep 2011 06:34:42 -0600 From: Stefan Hajnoczi Date: Tue, 13 Sep 2011 13:34:34 +0100 Message-Id: <1315917277-20670-2-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1315917277-20670-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1315917277-20670-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 1/4] trace: remove newline from grlib_irqmp_check_irqs format string List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , William Cohen , Stefan Hajnoczi There is no need to put a newline in trace event format strings. The backend may use the format string within some context and takes care of how to display the event. The stderr backend automatically appends "\n" whereas the ust backend does not want a newline at all. Signed-off-by: Stefan Hajnoczi --- trace-events | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/trace-events b/trace-events index a8e7684..cfcdc9b 100644 --- a/trace-events +++ b/trace-events @@ -327,7 +327,7 @@ grlib_gptimer_readl(int id, uint64_t addr, uint32_t val) "timer:%d addr 0x%"PRIx grlib_gptimer_writel(int id, uint64_t addr, uint32_t val) "timer:%d addr 0x%"PRIx64" 0x%x" # hw/grlib_irqmp.c -grlib_irqmp_check_irqs(uint32_t pend, uint32_t force, uint32_t mask, uint32_t lvl1, uint32_t lvl2) "pend:0x%04x force:0x%04x mask:0x%04x lvl1:0x%04x lvl0:0x%04x\n" +grlib_irqmp_check_irqs(uint32_t pend, uint32_t force, uint32_t mask, uint32_t lvl1, uint32_t lvl2) "pend:0x%04x force:0x%04x mask:0x%04x lvl1:0x%04x lvl0:0x%04x" grlib_irqmp_ack(int intno) "interrupt:%d" grlib_irqmp_set_irq(int irq) "Raise CPU IRQ %d" grlib_irqmp_readl_unknown(uint64_t addr) "addr 0x%"PRIx64"" -- 1.7.5.4