From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3le5-0000Nc-6s for qemu-devel@nongnu.org; Wed, 14 Sep 2011 05:20:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R3le2-0007zE-PL for qemu-devel@nongnu.org; Wed, 14 Sep 2011 05:20:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3le2-0007yu-CK for qemu-devel@nongnu.org; Wed, 14 Sep 2011 05:20:38 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8E9KbVp029435 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 14 Sep 2011 05:20:37 -0400 From: Kevin Wolf Date: Wed, 14 Sep 2011 11:23:34 +0200 Message-Id: <1315992214-3649-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH] raw-posix: Fix bdrv_flush error return values List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com bdrv_flush is supposed to use 0/-errno return values Signed-off-by: Kevin Wolf --- block/raw-posix.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index a624f56..305998d 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -839,7 +839,14 @@ static int raw_create(const char *filename, QEMUOptionParameter *options) static int raw_flush(BlockDriverState *bs) { BDRVRawState *s = bs->opaque; - return qemu_fdatasync(s->fd); + int ret; + + ret = qemu_fdatasync(s->fd); + if (ret < 0) { + return -errno; + } + + return 0; } #ifdef CONFIG_XFS -- 1.7.6