* [Qemu-devel] [PATCH] scsi-generic: do not disable FUA
@ 2011-09-14 13:25 Paolo Bonzini
2011-09-14 14:40 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Bonzini @ 2011-09-14 13:25 UTC (permalink / raw)
To: qemu-devel
I found no rationale for this in the logs, and it is quite bad because
it will make scsi-generic unsafe WRT power failures.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi-generic.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index 3202e5a..33a230f 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -244,12 +244,6 @@ static uint8_t *scsi_get_buf(SCSIRequest *req)
static void scsi_req_fixup(SCSIRequest *req)
{
switch(req->cmd.buf[0]) {
- case WRITE_10:
- req->cmd.buf[1] &= ~0x08; /* disable FUA */
- break;
- case READ_10:
- req->cmd.buf[1] &= ~0x08; /* disable FUA */
- break;
case REWIND:
case START_STOP:
if (req->dev->type == TYPE_TAPE) {
--
1.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] scsi-generic: do not disable FUA
2011-09-14 13:25 [Qemu-devel] [PATCH] scsi-generic: do not disable FUA Paolo Bonzini
@ 2011-09-14 14:40 ` Christoph Hellwig
2011-09-15 10:03 ` Kevin Wolf
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2011-09-14 14:40 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
On Wed, Sep 14, 2011 at 03:25:56PM +0200, Paolo Bonzini wrote:
> I found no rationale for this in the logs, and it is quite bad because
> it will make scsi-generic unsafe WRT power failures.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] scsi-generic: do not disable FUA
2011-09-14 14:40 ` Christoph Hellwig
@ 2011-09-15 10:03 ` Kevin Wolf
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2011-09-15 10:03 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Paolo Bonzini, qemu-devel
Am 14.09.2011 16:40, schrieb Christoph Hellwig:
> On Wed, Sep 14, 2011 at 03:25:56PM +0200, Paolo Bonzini wrote:
>> I found no rationale for this in the logs, and it is quite bad because
>> it will make scsi-generic unsafe WRT power failures.
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-15 10:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-14 13:25 [Qemu-devel] [PATCH] scsi-generic: do not disable FUA Paolo Bonzini
2011-09-14 14:40 ` Christoph Hellwig
2011-09-15 10:03 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).