From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, patches@linaro.org
Subject: [Qemu-devel] [PATCH 2/2] hw/usb-ohci: Fix OHCI_TD_T1 bit position definition
Date: Wed, 14 Sep 2011 18:49:00 +0100 [thread overview]
Message-ID: <1316022540-31355-3-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1316022540-31355-1-git-send-email-peter.maydell@linaro.org>
The OHCI Transfer Descriptor T (DataToggle) bits are 24 and 25;
fix an error which accidentally overlaid them both on the same bit.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/usb-ohci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/usb-ohci.c b/hw/usb-ohci.c
index 7487188..d314743 100644
--- a/hw/usb-ohci.c
+++ b/hw/usb-ohci.c
@@ -150,7 +150,7 @@ static void ohci_async_cancel_device(OHCIState *ohci, USBDevice *dev);
#define OHCI_TD_DI_SHIFT 21
#define OHCI_TD_DI_MASK (7<<OHCI_TD_DI_SHIFT)
#define OHCI_TD_T0 (1<<24)
-#define OHCI_TD_T1 (1<<24)
+#define OHCI_TD_T1 (1<<25)
#define OHCI_TD_EC_SHIFT 26
#define OHCI_TD_EC_MASK (3<<OHCI_TD_EC_SHIFT)
#define OHCI_TD_CC_SHIFT 28
--
1.7.1
next prev parent reply other threads:[~2011-09-14 17:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 17:48 [Qemu-devel] [PATCH 0/2] usb-ohci: fixes to allow usb-net to work Peter Maydell
2011-09-14 17:48 ` [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size Peter Maydell
2011-09-15 7:33 ` Gerd Hoffmann
2011-09-15 8:36 ` Peter Maydell
2011-09-15 9:13 ` Gerd Hoffmann
2011-09-15 10:08 ` Peter Maydell
2011-09-15 10:49 ` Gerd Hoffmann
2011-09-15 11:24 ` Peter Maydell
2011-09-15 11:45 ` Gerd Hoffmann
2011-09-14 17:49 ` Peter Maydell [this message]
2011-09-15 7:34 ` [Qemu-devel] [PATCH 2/2] hw/usb-ohci: Fix OHCI_TD_T1 bit position definition Gerd Hoffmann
2011-10-10 16:44 ` [Qemu-devel] [PATCH 0/2] usb-ohci: fixes to allow usb-net to work Peter Maydell
2011-10-11 7:10 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316022540-31355-3-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=kraxel@redhat.com \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).