From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R49vD-0005am-Kk for qemu-devel@nongnu.org; Thu, 15 Sep 2011 07:16:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R49vC-0006wL-N8 for qemu-devel@nongnu.org; Thu, 15 Sep 2011 07:15:59 -0400 From: Peter Maydell Date: Thu, 15 Sep 2011 12:15:56 +0100 Message-Id: <1316085356-632-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH] configure: Make missing pkg-config an error rather than a warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, patches@linaro.org If pkg-config doesn't exist then make configure fail immediately with a useful error message. Now that glib is a required dependency, proceeding despite the missing pkg-config will just cause us to fail later with a misleading message about glib not being present. Signed-off-by: Peter Maydell --- configure | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 0875f95..6c2839d 100755 --- a/configure +++ b/configure @@ -1339,8 +1339,8 @@ fi # pkg-config probe if ! has $pkg_config; then - echo warning: proceeding without "$pkg_config" >&2 - pkg_config=/bin/false + echo "Error: pkg-config binary '$pkg_config' not found" + exit 1 fi ########################################## -- 1.7.1