* [Qemu-devel] [PATCH] qdev: print bus properties too
@ 2011-09-16 9:25 Gerd Hoffmann
2011-09-23 14:44 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2011-09-16 9:25 UTC (permalink / raw)
To: qemu-devel; +Cc: ddutile, armbru, Gerd Hoffmann
Make qdev_device_help print both device and bus properties.
Helps libvirt to figure whenever bus properties such as
PCI.multifunction are supported present or not.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/qdev.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index c463c52..a223d41 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -207,6 +207,12 @@ int qdev_device_help(QemuOpts *opts)
}
error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name);
}
+ for (prop = info->bus_info->props; prop && prop->name; prop++) {
+ if (!prop->info->parse) {
+ continue; /* no way to set it, don't show */
+ }
+ error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name);
+ }
return 1;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] qdev: print bus properties too
2011-09-16 9:25 [Qemu-devel] [PATCH] qdev: print bus properties too Gerd Hoffmann
@ 2011-09-23 14:44 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2011-09-23 14:44 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: ddutile, qemu-devel, armbru
On 09/16/2011 04:25 AM, Gerd Hoffmann wrote:
> Make qdev_device_help print both device and bus properties.
> Helps libvirt to figure whenever bus properties such as
> PCI.multifunction are supported present or not.
>
> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> hw/qdev.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/hw/qdev.c b/hw/qdev.c
> index c463c52..a223d41 100644
> --- a/hw/qdev.c
> +++ b/hw/qdev.c
> @@ -207,6 +207,12 @@ int qdev_device_help(QemuOpts *opts)
> }
> error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name);
> }
> + for (prop = info->bus_info->props; prop&& prop->name; prop++) {
> + if (!prop->info->parse) {
> + continue; /* no way to set it, don't show */
> + }
> + error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name);
> + }
> return 1;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-23 14:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-16 9:25 [Qemu-devel] [PATCH] qdev: print bus properties too Gerd Hoffmann
2011-09-23 14:44 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).