qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [RFC PATCH 10/14] Revert to a hand-made select loop
Date: Fri, 16 Sep 2011 17:09:06 +0200	[thread overview]
Message-ID: <1316185750-9187-11-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1316185750-9187-1-git-send-email-pbonzini@redhat.com>

This reverts commit c82dc29a9112f34e0a51cad9a412cf6d9d05dfb2
and 4d88a2ac8643265108ef1fb47ceee5d7b28e19f2.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 iohandler.c |   54 +-----------------------------------------------------
 1 files changed, 1 insertions(+), 53 deletions(-)

diff --git a/iohandler.c b/iohandler.c
index 4cc1c5a..4deae1e 100644
--- a/iohandler.c
+++ b/iohandler.c
@@ -80,64 +80,12 @@ int qemu_set_fd_handler2(int fd,
     return 0;
 }
 
-typedef struct IOTrampoline
-{
-    GIOChannel *chan;
-    IOHandler *fd_read;
-    IOHandler *fd_write;
-    void *opaque;
-    guint tag;
-} IOTrampoline;
-
-static gboolean fd_trampoline(GIOChannel *chan, GIOCondition cond, gpointer opaque)
-{
-    IOTrampoline *tramp = opaque;
-
-    if ((cond & G_IO_IN) && tramp->fd_read) {
-        tramp->fd_read(tramp->opaque);
-    }
-
-    if ((cond & G_IO_OUT) && tramp->fd_write) {
-        tramp->fd_write(tramp->opaque);
-    }
-
-    return TRUE;
-}
-
 int qemu_set_fd_handler(int fd,
                         IOHandler *fd_read,
                         IOHandler *fd_write,
                         void *opaque)
 {
-    static IOTrampoline fd_trampolines[FD_SETSIZE];
-    IOTrampoline *tramp = &fd_trampolines[fd];
-
-    if (tramp->tag != 0) {
-        g_io_channel_unref(tramp->chan);
-        g_source_remove(tramp->tag);
-        tramp->tag = 0;
-    }
-
-    if (fd_read || fd_write || opaque) {
-        GIOCondition cond = 0;
-
-        tramp->fd_read = fd_read;
-        tramp->fd_write = fd_write;
-        tramp->opaque = opaque;
-
-        if (fd_read) {
-            cond |= G_IO_IN | G_IO_ERR;
-        }
-
-        if (fd_write) {
-            cond |= G_IO_OUT | G_IO_ERR;
-        }
-
-        tramp->chan = g_io_channel_unix_new(fd);
-        tramp->tag = g_io_add_watch(tramp->chan, cond, fd_trampoline, tramp);
-    }
-
-    return 0;
+    return qemu_set_fd_handler2(fd, NULL, fd_read, fd_write, opaque);
 }
 
 void qemu_iohandler_fill(int *pnfds, fd_set *readfds, fd_set *writefds, fd_set *xfds)
-- 
1.7.6

  parent reply	other threads:[~2011-09-16 15:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-16 15:08 [Qemu-devel] [RFC PATCH 00/14] allow tools to use the QEMU main loop Paolo Bonzini
2011-09-16 15:08 ` [Qemu-devel] [RFC PATCH 01/14] remove unused function Paolo Bonzini
2011-09-16 15:08 ` [Qemu-devel] [RFC PATCH 02/14] qemu-timer: remove active_timers array Paolo Bonzini
2011-09-16 15:08 ` [Qemu-devel] [RFC PATCH 03/14] qemu-timer: move common code to qemu_rearm_alarm_timer Paolo Bonzini
2011-09-16 15:09 ` [Qemu-devel] [RFC PATCH 04/14] qemu-timer: more clock functions Paolo Bonzini
2011-09-16 15:09 ` [Qemu-devel] [RFC PATCH 05/14] qemu-timer: move icount to cpus.c Paolo Bonzini
2011-09-16 15:09 ` [Qemu-devel] [RFC PATCH 06/14] qemu-timer: do not refer to vm_running Paolo Bonzini
2011-09-16 15:09 ` [Qemu-devel] [RFC PATCH 07/14] qemu-timer: move more stuff out of qemu-timer.c Paolo Bonzini
2011-09-16 15:09 ` [Qemu-devel] [RFC PATCH 08/14] create main-loop.h Paolo Bonzini
2011-09-16 15:09 ` [Qemu-devel] [RFC PATCH 09/14] create main-loop.c Paolo Bonzini
2011-09-16 15:09 ` Paolo Bonzini [this message]
2011-09-16 15:09 ` [Qemu-devel] [RFC PATCH 11/14] simplify main loop functions Paolo Bonzini
2011-09-16 15:09 ` [Qemu-devel] [RFC PATCH 12/14] makefile: extract tools-obj-y Paolo Bonzini
2011-09-16 15:09 ` [Qemu-devel] [RFC PATCH 13/14] link the main loop and its dependencies into the tools Paolo Bonzini
2011-09-16 15:09 ` [Qemu-devel] [RFC PATCH 14/14] qemu-nbd: use common main loop Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316185750-9187-11-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).