[Qemu-devel] [PATCH] remove mpc8544ds.dtb

[Qemu-devel] [PATCH] remove mpc8544ds.dtb

[Stuart Yoder]

From: Stuart Yoder <stuart.yoder@freescale.com>

make install now compiles dtb

Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
---

apply after 'support compiling and installing DTBs'

 pc-bios/mpc8544ds.dtb |  Bin 2277 -> 0 bytes
 1 files changed, 0 insertions(+), 0 deletions(-)
 delete mode 100644 pc-bios/mpc8544ds.dtb

diff --git a/pc-bios/mpc8544ds.dtb b/pc-bios/mpc8544ds.dtb
deleted file mode 100644
index ae318b1fe83846cc2e133951a3666fcfcdf87f79..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 2277
zcmb7Fy>C=U5Z@O^han^~5(T1&EZjuso_v<hmWvd3GNeOtl#(KP-dlVtzpw1RbIw#2
z6&?HylvMl)?r0G`k|`)j9U5SMvpdi44!K~Yc{?A!nVsF8-S_6_&mWaq{h*ZERqD!|
z#@~o<5U&vvB?Z|>EG~YMsIJg>4f2Eiz1{8M@ZMj+0sBqj-i4i|`8*)t|B)DTA(!au
zQBShmX5M&G+4n1r{Y_tKOfoWqK%3q;o8_b7_Fw?y1$KBjcBhN|g<^i+thMEwyOfsG
zs2^xZbUot&V&2Q@MMSb+{cGI*UZ3j=Nn}l9$^(q(51<f<{wK-n9bGT!6nsji7XM^P
ze+DO!<a-g+R(}<BtcllEn4)qgY(>l!;_;Ggm26TcfE>5H{csS;yqBG&_{S74_@7AV
zd0W)ENe|*K19zSHj98uHvxX1n=X%arWuxSjwI)lQApX}J5_0f51CFi0AaAeqTRYp^
zd}v~$wcjTfx4Gn!eH6@F0^B9W-U#Mh3<~=dyEAs2U{I6v{CC#$M+|M}`|g@*t4BlJ
z9?C?7nn3>%OMN&;P}CEQvc}LCxC!8Z!5!-9sjK@{ZOW8pU>C<<C2_oHZu8=OkbR(R
z$?d4~-W}%EL6)bp#^$!M#)mu4iBS(~>^<^%zo_|1NDpUC_pXLIQCVmr#1JKS=!5(`
z$G6vBYE#|5StERBu0cw1WNNYFj!xKww)TJcg>c50|D1e#N<9@jMywyq^(^_KjbjP3
z5Qlt-!znELqD^u?CrC?(0mt|SpUfBI7kn~b#4Pxh=4<yw?gC<Q9=I>Jh>;`O61;t&
zFT}77h|d53okfPcPK?5Z-ir{7h(#T*Rz8hh(inB_T_D82PO{7oJo*SeF!#*4Iwf(9
zIGl-|R^F6Q8AJb}<l*K2mi9ly`!qeNjXSo!avTpE_-av2Os;fQ)LCN>a-%k~$;27&
zQ*H9xs|{}-n<$6(YM{cnrKr~iYGRJ9Hh(viUpaHACaKQ!)TFsBO^RS;zp)5r!Ocoz
z3v)m}+w_q$|IAFOPZT}L9ZlzzKI-T$D-Y?{jABz;PRv}{vN6uhYPy51nAVvyWz#X}
zs%%`9=f<gx3s_h)l|GyI>uFX_XhU$br<qTkZ?x-VD6%>&GJmva;&Qnt71H=-Qq3AF
HpqZ+#N9HOV

-- 
1.7.3.4

Re: [Qemu-devel] [PATCH] remove mpc8544ds.dtb

[Alexander Graf]

On 16.09.2011, at 21:05, Stuart Yoder wrote:

> From: Stuart Yoder <stuart.yoder@freescale.com>
> 
> make install now compiles dtb

It doesn't when you don't have dtb installed, breaking the e500 target for build environments that don't have dtb. I don't think that's a good idea. It's not been too painful upstream to keep the dtb and dts in sync.


Alex

Re: [Qemu-devel] [PATCH] remove mpc8544ds.dtb

[Scott Wood]

On 09/24/2011 02:32 AM, Alexander Graf wrote:
> 
> On 16.09.2011, at 21:05, Stuart Yoder wrote:
> 
>> From: Stuart Yoder <stuart.yoder@freescale.com>
>>
>> make install now compiles dtb
> 
> It doesn't when you don't have dtb installed, breaking the e500
> target for build environments that don't have dtb. I don't think
> that's a good idea. It's not been too painful upstream to keep the
> dtb and dts in sync.

So now we're avoiding new dependencies. :-)

It was more of an annoyance in internal development as we were
frequently changing the device tree to configure device assignment and
such.  For mainline QEMU the long-term plan should be to get rid of the
static device tree entirely, and to avoid doing configuration that way
in the first place, so it's not that big of a deal to keep both .dts and
.dtb around until then.

-Scott

Re: [Qemu-devel] [PATCH] remove mpc8544ds.dtb

[Alexander Graf]

On 27.09.2011, at 23:58, Scott Wood wrote:

> On 09/24/2011 02:32 AM, Alexander Graf wrote:
>> 
>> On 16.09.2011, at 21:05, Stuart Yoder wrote:
>> 
>>> From: Stuart Yoder <stuart.yoder@freescale.com>
>>> 
>>> make install now compiles dtb
>> 
>> It doesn't when you don't have dtb installed, breaking the e500
>> target for build environments that don't have dtb. I don't think
>> that's a good idea. It's not been too painful upstream to keep the
>> dtb and dts in sync.
> 
> So now we're avoiding new dependencies. :-)

Sure, it's always painful to add new dependencies. If adding a new dependency buys us a tremendous amount of comfort, I'll happily do it. However, this is only a convenience thing for whoever changes the dts. And every change to the dts should go through upstream. And there I'll generate the dtb. :)

> 
> It was more of an annoyance in internal development as we were
> frequently changing the device tree to configure device assignment and
> such.  For mainline QEMU the long-term plan should be to get rid of the
> static device tree entirely, and to avoid doing configuration that way
> in the first place, so it's not that big of a deal to keep both .dts and
> .dtb around until then.

Yup. Worst case we'd keep around a minimal dtb that doesn't need to be modified too often, but yes.


Alex