qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 03/20] nbd: support NBD_SET_FLAGS ioctl
Date: Tue, 20 Sep 2011 13:11:35 +0200	[thread overview]
Message-ID: <1316517112-9908-4-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1316517112-9908-1-git-send-email-kwolf@redhat.com>

From: Paolo Bonzini <pbonzini@redhat.com>

The nbd kernel module cannot enable DISCARD requests unless it is
informed about it.  The flags field in the header is used for this,
and this patch adds support for it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 nbd.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/nbd.c b/nbd.c
index d32a19e..595f4d8 100644
--- a/nbd.c
+++ b/nbd.c
@@ -378,6 +378,14 @@ int nbd_init(int fd, int csock, uint32_t flags, off_t size, size_t blocksize)
         }
     }
 
+    if (ioctl(fd, NBD_SET_FLAGS, flags) < 0
+        && errno != ENOTTY) {
+        int serrno = errno;
+        LOG("Failed setting flags");
+        errno = serrno;
+        return -1;
+    }
+
     TRACE("Clearing NBD socket");
 
     if (ioctl(fd, NBD_CLEAR_SOCK) == -1) {
-- 
1.7.6.2

  parent reply	other threads:[~2011-09-20 11:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-20 11:11 [Qemu-devel] [PULL 00/20] Block patches Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 01/20] nbd: support feature negotiation Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 02/20] nbd: sync API definitions with upstream Kevin Wolf
2011-09-20 11:11 ` Kevin Wolf [this message]
2011-09-20 11:11 ` [Qemu-devel] [PATCH 04/20] raw-posix: Fix bdrv_flush error return values Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 05/20] scsi-generic: do not disable FUA Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 06/20] dma-helpers: rename is_write to to_dev Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 07/20] dma-helpers: allow including from target-independent code Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 08/20] dma-helpers: rewrite completion/cancellation Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 09/20] scsi-disk: commonize iovec creation between reads and writes Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 10/20] scsi-disk: lazily allocate bounce buffer Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 11/20] VMDK: fix leak of extent_file Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 12/20] posix-aio-compat: Removed unused offset variable Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 13/20] AHCI Port Interrupt Enable register cleaning on soft reset Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 14/20] rbd: ignore failures when reading from default conf location Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 15/20] rbd: update comment heading Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 16/20] rbd: call flush, if available Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 17/20] scsi: fix sign extension problems Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 18/20] block: avoid SIGUSR2 Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 19/20] linux-aio: remove process requests callback Kevin Wolf
2011-09-20 11:11 ` [Qemu-devel] [PATCH 20/20] rbd: allow escaping in config string Kevin Wolf
2011-09-20 20:39 ` [Qemu-devel] [PULL 00/20] Block patches Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316517112-9908-4-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).