From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5yCO-0004pA-GR for qemu-devel@nongnu.org; Tue, 20 Sep 2011 07:09:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5yCF-0008VL-SR for qemu-devel@nongnu.org; Tue, 20 Sep 2011 07:09:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5yCF-0008V7-9d for qemu-devel@nongnu.org; Tue, 20 Sep 2011 07:09:03 -0400 From: Kevin Wolf Date: Tue, 20 Sep 2011 13:11:36 +0200 Message-Id: <1316517112-9908-5-git-send-email-kwolf@redhat.com> In-Reply-To: <1316517112-9908-1-git-send-email-kwolf@redhat.com> References: <1316517112-9908-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 04/20] raw-posix: Fix bdrv_flush error return values List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org bdrv_flush is supposed to use 0/-errno return values Signed-off-by: Kevin Wolf --- block/raw-posix.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index a624f56..305998d 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -839,7 +839,14 @@ static int raw_create(const char *filename, QEMUOptionParameter *options) static int raw_flush(BlockDriverState *bs) { BDRVRawState *s = bs->opaque; - return qemu_fdatasync(s->fd); + int ret; + + ret = qemu_fdatasync(s->fd); + if (ret < 0) { + return -errno; + } + + return 0; } #ifdef CONFIG_XFS -- 1.7.6.2