From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5yCI-0004ZE-Ty for qemu-devel@nongnu.org; Tue, 20 Sep 2011 07:09:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5yCG-0008Vh-SD for qemu-devel@nongnu.org; Tue, 20 Sep 2011 07:09:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5yCG-0008VZ-FS for qemu-devel@nongnu.org; Tue, 20 Sep 2011 07:09:04 -0400 From: Kevin Wolf Date: Tue, 20 Sep 2011 13:11:37 +0200 Message-Id: <1316517112-9908-6-git-send-email-kwolf@redhat.com> In-Reply-To: <1316517112-9908-1-git-send-email-kwolf@redhat.com> References: <1316517112-9908-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 05/20] scsi-generic: do not disable FUA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Paolo Bonzini I found no rationale for this in the logs, and it is quite bad because it will make scsi-generic unsafe WRT power failures. Signed-off-by: Paolo Bonzini Reviewed-by: Christoph Hellwig Signed-off-by: Kevin Wolf --- hw/scsi-generic.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c index 5ce01af..8f6b70d 100644 --- a/hw/scsi-generic.c +++ b/hw/scsi-generic.c @@ -244,12 +244,6 @@ static uint8_t *scsi_get_buf(SCSIRequest *req) static void scsi_req_fixup(SCSIRequest *req) { switch(req->cmd.buf[0]) { - case WRITE_10: - req->cmd.buf[1] &= ~0x08; /* disable FUA */ - break; - case READ_10: - req->cmd.buf[1] &= ~0x08; /* disable FUA */ - break; case REWIND: case START_STOP: if (req->dev->type == TYPE_TAPE) { -- 1.7.6.2