* [Qemu-devel] [PATCH] fix error: variable 'pid' set but not used
@ 2011-09-20 12:18 Paolo Bonzini
2011-09-20 12:20 ` Stefan Hajnoczi
2011-09-20 12:37 ` Kevin Wolf
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2011-09-20 12:18 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf
/home/pbonzini/work/upstream/qemu/posix-aio-compat.c: In function 'aio_thread':
/home/pbonzini/work/upstream/qemu/posix-aio-compat.c:314:11: error: variable 'pid' set but not used [-Werror=unused-but-set-variable]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
Kevin, can you add this to your block branch pull for today?
posix-aio-compat.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/posix-aio-compat.c b/posix-aio-compat.c
index 393fa4b..d3c1174 100644
--- a/posix-aio-compat.c
+++ b/posix-aio-compat.c
@@ -311,10 +311,6 @@ static void posix_aio_notify_event(void);
static void *aio_thread(void *unused)
{
- pid_t pid;
-
- pid = getpid();
-
mutex_lock(&lock);
pending_threads--;
mutex_unlock(&lock);
--
1.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] fix error: variable 'pid' set but not used
2011-09-20 12:18 [Qemu-devel] [PATCH] fix error: variable 'pid' set but not used Paolo Bonzini
@ 2011-09-20 12:20 ` Stefan Hajnoczi
2011-09-20 12:37 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2011-09-20 12:20 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: kwolf, qemu-devel
On Tue, Sep 20, 2011 at 1:18 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> /home/pbonzini/work/upstream/qemu/posix-aio-compat.c: In function 'aio_thread':
> /home/pbonzini/work/upstream/qemu/posix-aio-compat.c:314:11: error: variable 'pid' set but not used [-Werror=unused-but-set-variable]
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> Kevin, can you add this to your block branch pull for today?
>
> posix-aio-compat.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] fix error: variable 'pid' set but not used
2011-09-20 12:18 [Qemu-devel] [PATCH] fix error: variable 'pid' set but not used Paolo Bonzini
2011-09-20 12:20 ` Stefan Hajnoczi
@ 2011-09-20 12:37 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2011-09-20 12:37 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
Am 20.09.2011 14:18, schrieb Paolo Bonzini:
> /home/pbonzini/work/upstream/qemu/posix-aio-compat.c: In function 'aio_thread':
> /home/pbonzini/work/upstream/qemu/posix-aio-compat.c:314:11: error: variable 'pid' set but not used [-Werror=unused-but-set-variable]
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> Kevin, can you add this to your block branch pull for today?
Thanks, merged it into Frediano's patch that caused the warning and
pushed the update to my for-anthony branch.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-20 12:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-20 12:18 [Qemu-devel] [PATCH] fix error: variable 'pid' set but not used Paolo Bonzini
2011-09-20 12:20 ` Stefan Hajnoczi
2011-09-20 12:37 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).