qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: wenyi <wenyi@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu: Fix build failure without VNC support
Date: Wed, 21 Sep 2011 15:21:05 +0800	[thread overview]
Message-ID: <1316589665.20124.3.camel@wayne-ThinkPad-T61> (raw)

        Hello!
        
        Qemu 0.15.0 doesn't build with vnc support disabled. The
        following
        patch fixes the problem.
        
        Signed-off-by: Boris Dolgov <address@hidden>
        
        --
        
        --- monitor.c.orig      2011-09-14 18:11:12.235199764 +0400
        +++ monitor.c   2011-09-14 18:12:19.187709823 +0400
        @@ -1200,10 +1200,12 @@ static int add_graphics_client(Monitor *
                 }
                qerror_report(QERR_ADD_CLIENT_FAILED);
                return -1;
        +#ifdef CONFIG_VNC
             } else if (strcmp(protocol, "vnc") == 0) {
                int fd = monitor_get_fd(mon, fdname);
                vnc_display_add_client(NULL, fd, skipauth);
                return 0;
        +#endif
             } else if ((s = qemu_chr_find(protocol)) != NULL) {
                int fd = monitor_get_fd(mon, fdname);
                if (qemu_chr_add_client(s, fd) < 0) {


Yes, the patch works fine.
        

             reply	other threads:[~2011-09-21  7:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-21  7:21 wenyi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-09-14 14:16 [Qemu-devel] [PATCH] qemu: Fix build failure without VNC support Boris Dolgov
2011-09-16 13:13 ` Anthony Liguori
2011-09-16 13:23   ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316589665.20124.3.camel@wayne-ThinkPad-T61 \
    --to=wenyi@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).