From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 2/8] configure: Make missing pkg-config an error rather than a warning
Date: Wed, 21 Sep 2011 11:26:00 +0100 [thread overview]
Message-ID: <1316600766-5541-3-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1316600766-5541-1-git-send-email-stefanha@linux.vnet.ibm.com>
From: Peter Maydell <peter.maydell@linaro.org>
If pkg-config doesn't exist then make configure fail immediately
with a useful error message. Now that glib is a required dependency,
proceeding despite the missing pkg-config will just cause us to
fail later with a misleading message about glib not being present.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
configure | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 414317a..9ab3ab4 100755
--- a/configure
+++ b/configure
@@ -1340,8 +1340,8 @@ fi
# pkg-config probe
if ! has $pkg_config; then
- echo warning: proceeding without "$pkg_config" >&2
- pkg_config=/bin/false
+ echo "Error: pkg-config binary '$pkg_config' not found"
+ exit 1
fi
##########################################
--
1.7.5.4
next prev parent reply other threads:[~2011-09-21 10:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 10:25 [Qemu-devel] [PULL 0/8] Trivial patches for September 10 to 21 2011 Stefan Hajnoczi
2011-09-21 10:25 ` [Qemu-devel] [PATCH 1/8] target-i386: Remove data type CCTable Stefan Hajnoczi
2011-09-21 10:26 ` Stefan Hajnoczi [this message]
2011-09-21 10:26 ` [Qemu-devel] [PATCH 3/8] fix compilation with stderr trace backend Stefan Hajnoczi
2011-09-21 10:26 ` [Qemu-devel] [PATCH 4/8] Drop unneeded pthread.h inclusions Stefan Hajnoczi
2011-09-21 10:26 ` [Qemu-devel] [PATCH 5/8] Silence make if nothing is to do for libcacard Stefan Hajnoczi
2011-09-21 10:26 ` [Qemu-devel] [PATCH 6/8] Abort on thread layer errors Stefan Hajnoczi
2011-09-21 10:26 ` [Qemu-devel] [PATCH 7/8] Remove qemu_host_page_bits Stefan Hajnoczi
2011-09-21 10:26 ` [Qemu-devel] [PATCH 8/8] use qemu_* ctype functions Stefan Hajnoczi
2011-09-22 15:58 ` [Qemu-devel] [PULL 0/8] Trivial patches for September 10 to 21 2011 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316600766-5541-3-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).