From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6K0P-0007ZJ-Vl for qemu-devel@nongnu.org; Wed, 21 Sep 2011 06:26:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6K0M-0006OE-CE for qemu-devel@nongnu.org; Wed, 21 Sep 2011 06:26:17 -0400 Received: from mtagate7.uk.ibm.com ([194.196.100.167]:33680) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6K0M-0006O3-48 for qemu-devel@nongnu.org; Wed, 21 Sep 2011 06:26:14 -0400 Received: from d06nrmr1307.portsmouth.uk.ibm.com (d06nrmr1307.portsmouth.uk.ibm.com [9.149.38.129]) by mtagate7.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p8LAQDBK017458 for ; Wed, 21 Sep 2011 10:26:13 GMT Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p8LAQDnw2437166 for ; Wed, 21 Sep 2011 11:26:13 +0100 Received: from d06av03.portsmouth.uk.ibm.com (localhost.localdomain [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p8LHQAOQ014490 for ; Wed, 21 Sep 2011 11:26:10 -0600 From: Stefan Hajnoczi Date: Wed, 21 Sep 2011 11:26:00 +0100 Message-Id: <1316600766-5541-3-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1316600766-5541-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1316600766-5541-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 2/8] configure: Make missing pkg-config an error rather than a warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Anthony Liguori , Stefan Hajnoczi From: Peter Maydell If pkg-config doesn't exist then make configure fail immediately with a useful error message. Now that glib is a required dependency, proceeding despite the missing pkg-config will just cause us to fail later with a misleading message about glib not being present. Signed-off-by: Peter Maydell Acked-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- configure | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 414317a..9ab3ab4 100755 --- a/configure +++ b/configure @@ -1340,8 +1340,8 @@ fi # pkg-config probe if ! has $pkg_config; then - echo warning: proceeding without "$pkg_config" >&2 - pkg_config=/bin/false + echo "Error: pkg-config binary '$pkg_config' not found" + exit 1 fi ########################################## -- 1.7.5.4