From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6KAc-0004K6-2f for qemu-devel@nongnu.org; Wed, 21 Sep 2011 06:36:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6KAa-0008Md-SZ for qemu-devel@nongnu.org; Wed, 21 Sep 2011 06:36:50 -0400 Received: from mtagate1.uk.ibm.com ([194.196.100.161]:49307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6KAa-0008MI-C1 for qemu-devel@nongnu.org; Wed, 21 Sep 2011 06:36:48 -0400 Received: from d06nrmr1507.portsmouth.uk.ibm.com (d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233]) by mtagate1.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p8LAakDe003200 for ; Wed, 21 Sep 2011 10:36:46 GMT Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p8LAajIZ2359356 for ; Wed, 21 Sep 2011 11:36:46 +0100 Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p8LHamrK029705 for ; Wed, 21 Sep 2011 11:36:48 -0600 From: Stefan Hajnoczi Date: Wed, 21 Sep 2011 11:36:36 +0100 Message-Id: <1316601397-19287-5-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1316601397-19287-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1316601397-19287-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 4/5] trace: use binary file open mode in simpletrace List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Stefan Hajnoczi For Windows portability the simple trace backend must use the 'b' file open mode. This prevents the stdio library from mangling 0x0a/0x0d newline characters. Signed-off-by: Stefan Hajnoczi --- trace/simple.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/trace/simple.c b/trace/simple.c index 885764a..b639dda 100644 --- a/trace/simple.c +++ b/trace/simple.c @@ -234,7 +234,7 @@ void st_set_trace_file_enabled(bool enable) .x1 = HEADER_VERSION, }; - trace_fp = fopen(trace_file_name, "w"); + trace_fp = fopen(trace_file_name, "wb"); if (!trace_fp) { return; } -- 1.7.5.4