qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: nick@bytemark.co.uk
To: nick@bytemark.co.uk, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: [Qemu-devel] block/curl: Remedy a crashing bug completing AIOCBs from cache
Date: Wed, 21 Sep 2011 11:55:48 +0100	[thread overview]
Message-ID: <1316602550-13597-1-git-send-email-nick@bytemark.co.uk> (raw)

In QEMU master, attempting to read a cached block from a HTTP (or otherwise)
mounted ISO causes an assert to be triggered, killing the entire QEMU process.
It looks like this:

hw/ide/pci.c:314: bmdma_cmd_writeb: Assertion `bm->bus->dma->aiocb == 
((void *)0)' failed.

The following two patches add flush capability to the curl backend, and avoid
triggering the assert by finishing the AIOCB in a QEMUBH callback, rather than
directly in curl_aio_readv().

             reply	other threads:[~2011-09-21 10:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-21 10:55 nick [this message]
2011-09-21 10:55 ` [Qemu-devel] [PATCH 1/2] block/curl: Implement a flush function on the fd handlers nick
2011-09-21 10:55 ` [Qemu-devel] [PATCH 2/2] block/curl: Don't finish AIOCBs too early nick
2011-09-21 13:32 ` [Qemu-devel] block/curl: Remedy a crashing bug completing AIOCBs from cache Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316602550-13597-1-git-send-email-nick@bytemark.co.uk \
    --to=nick@bytemark.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).