From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 13/14] serial: Convert serial_isa_initfn to MemoryRegion
Date: Sun, 25 Sep 2011 15:50:48 +0300 [thread overview]
Message-ID: <1316955049-21516-14-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1316955049-21516-1-git-send-email-avi@redhat.com>
From: Richard Henderson <rth@twiddle.net>
The serial_mm_init path is as yet unconverted.
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Avi Kivity <avi@redhat.com>
---
hw/serial.c | 15 ++++++++++++---
1 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/hw/serial.c b/hw/serial.c
index ed7fd0a..2e6d212 100644
--- a/hw/serial.c
+++ b/hw/serial.c
@@ -157,6 +157,7 @@ struct SerialState {
typedef struct ISASerialState {
ISADevice dev;
+ MemoryRegion io;
uint32_t index;
uint32_t iobase;
uint32_t isairq;
@@ -755,6 +756,15 @@ void serial_set_frequency(SerialState *s, uint32_t frequency)
static const int isa_serial_io[MAX_SERIAL_PORTS] = { 0x3f8, 0x2f8, 0x3e8, 0x2e8 };
static const int isa_serial_irq[MAX_SERIAL_PORTS] = { 4, 3, 4, 3 };
+static const MemoryRegionPortio serial_portio[] = {
+ { 0, 8, 1, .read = serial_ioport_read, .write = serial_ioport_write },
+ PORTIO_END_OF_LIST()
+};
+
+static const MemoryRegionOps serial_io_ops = {
+ .old_portio = serial_portio
+};
+
static int serial_isa_initfn(ISADevice *dev)
{
static int index;
@@ -776,9 +786,8 @@ static int serial_isa_initfn(ISADevice *dev)
serial_init_core(s);
qdev_set_legacy_instance_id(&dev->qdev, isa->iobase, 3);
- register_ioport_write(isa->iobase, 8, 1, serial_ioport_write, s);
- register_ioport_read(isa->iobase, 8, 1, serial_ioport_read, s);
- isa_init_ioport_range(dev, isa->iobase, 8);
+ memory_region_init_io(&isa->io, &serial_io_ops, s, "serial", 8);
+ isa_register_ioport(dev, &isa->io, isa->iobase);
return 0;
}
--
1.7.6.3
next prev parent reply other threads:[~2011-09-25 12:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-25 12:50 [Qemu-devel] [PULL 00/14] Memory API conversion batch 9: ISA Avi Kivity
2011-09-25 12:50 ` [Qemu-devel] [PATCH 01/14] pci: add pci_address_space_io() Avi Kivity
2011-09-25 12:50 ` [Qemu-devel] [PATCH 02/14] isa: Pass i/o address space to isa_bus_new Avi Kivity
2011-09-25 12:50 ` [Qemu-devel] [PATCH 03/14] isa: add isa_register_ioport() Avi Kivity
2011-09-25 12:50 ` [Qemu-devel] [PATCH 04/14] pc: Re-order pc_init1 to initialize the ISA bus before ISA devices Avi Kivity
2011-09-25 12:50 ` [Qemu-devel] [PATCH 05/14] cs4231a: Convert to MemoryRegion Avi Kivity
2011-09-25 12:50 ` [Qemu-devel] [PATCH 06/14] i8254: " Avi Kivity
2011-09-25 12:50 ` [Qemu-devel] [PATCH 07/14] mips_malta: move i8259 initialization after piix4 initialization Avi Kivity
2011-09-25 12:50 ` [Qemu-devel] [PATCH 08/14] mips_jazz: initialize i8259 after the ISA bus Avi Kivity
2011-09-25 12:50 ` [Qemu-devel] [PATCH 09/14] mips_r4k: " Avi Kivity
2011-09-25 12:50 ` [Qemu-devel] [PATCH 10/14] ppc_prep: " Avi Kivity
2011-09-25 12:50 ` [Qemu-devel] [PATCH 11/14] i8259: Convert to MemoryRegion Avi Kivity
2011-09-25 12:50 ` [Qemu-devel] [PATCH 12/14] pckbd: " Avi Kivity
2011-09-25 12:50 ` Avi Kivity [this message]
2011-09-25 12:50 ` [Qemu-devel] [PATCH 14/14] fdc: Convert isabus_fdc_init1 " Avi Kivity
2011-09-26 13:29 ` [Qemu-devel] [PULL 00/14] Memory API conversion batch 9: ISA Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316955049-21516-14-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).