* [Qemu-devel] [PATCH] softfloat: Reinstate accidentally disabled target-specific NaN handling
@ 2011-09-26 15:56 Peter Maydell
2011-10-01 12:04 ` Blue Swirl
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2011-09-26 15:56 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Paolo Bonzini, patches
Include config.h in softfloat.c, so that the target specific ifdefs in
softfloat-specialize.h are evaluated correctly. This was accidentally
broken in commit 789ec7ce2 when config-target.h was removed from
softfloat.h, and means that most targets will have been returning the
wrong results for calculations involving NaNs.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
fpu/softfloat.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index 2b20085..3aafa81 100644
--- a/fpu/softfloat.c
+++ b/fpu/softfloat.c
@@ -35,6 +35,11 @@ these four paragraphs for those parts of this code that are retained.
=============================================================================*/
+/* softfloat (and in particular the code in softfloat-specialize.h) is
+ * target-dependent and needs the TARGET_* macros.
+ */
+#include "config.h"
+
#include "softfloat.h"
/*----------------------------------------------------------------------------
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] softfloat: Reinstate accidentally disabled target-specific NaN handling
2011-09-26 15:56 [Qemu-devel] [PATCH] softfloat: Reinstate accidentally disabled target-specific NaN handling Peter Maydell
@ 2011-10-01 12:04 ` Blue Swirl
0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2011-10-01 12:04 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, Paolo Bonzini, qemu-devel, patches
Thanks, applied.
On Mon, Sep 26, 2011 at 3:56 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> Include config.h in softfloat.c, so that the target specific ifdefs in
> softfloat-specialize.h are evaluated correctly. This was accidentally
> broken in commit 789ec7ce2 when config-target.h was removed from
> softfloat.h, and means that most targets will have been returning the
> wrong results for calculations involving NaNs.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> fpu/softfloat.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index 2b20085..3aafa81 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -35,6 +35,11 @@ these four paragraphs for those parts of this code that are retained.
>
> =============================================================================*/
>
> +/* softfloat (and in particular the code in softfloat-specialize.h) is
> + * target-dependent and needs the TARGET_* macros.
> + */
> +#include "config.h"
> +
> #include "softfloat.h"
>
> /*----------------------------------------------------------------------------
> --
> 1.7.1
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-01 12:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-26 15:56 [Qemu-devel] [PATCH] softfloat: Reinstate accidentally disabled target-specific NaN handling Peter Maydell
2011-10-01 12:04 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).