From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9DwK-0000cn-Vl for qemu-devel@nongnu.org; Thu, 29 Sep 2011 06:34:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R9DwJ-0002ji-Lp for qemu-devel@nongnu.org; Thu, 29 Sep 2011 06:34:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9DwJ-0002iw-B4 for qemu-devel@nongnu.org; Thu, 29 Sep 2011 06:34:03 -0400 From: "Daniel P. Berrange" Date: Thu, 29 Sep 2011 11:33:44 +0100 Message-Id: <1317292424-12239-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PATCH] Ensure an error is reported to user if 9pfs mount tag is too long List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Harsh Bora , "Aneesh Kumar K. V" From: "Daniel P. Berrange" If the 9pfs mount tag is longer than MAX_TAG_LEN bytes, rather than silently truncating the tag which will likely break the guest OS, report an immediate error and exit QEMU * hw/9pfs/virtio-9p-device.c: Report error & exit if mount tag is too long Signed-off-by: Daniel P. Berrange --- hw/9pfs/virtio-9p-device.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index 97f2da5..8ca38d3 100644 --- a/hw/9pfs/virtio-9p-device.c +++ b/hw/9pfs/virtio-9p-device.c @@ -117,7 +117,9 @@ VirtIODevice *virtio_9p_init(DeviceState *dev, V9fsConf *conf) s->ctx.fs_root = g_strdup(fse->path); len = strlen(conf->tag); if (len > MAX_TAG_LEN) { - len = MAX_TAG_LEN; + fprintf(stderr, "mount tag '%s' (%d bytes) is longer than maximum (%d bytes)", + conf->tag, len, MAX_TAG_LEN); + exit(1); } /* s->tag is non-NULL terminated string */ s->tag = g_malloc(len); -- 1.7.6.2