qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: Harsh Bora <harsh@linux.vnet.ibm.com>,
	"Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH] Raise 9pfs mount_tag limit from 32 to 255 bytes
Date: Thu, 29 Sep 2011 11:34:21 +0100	[thread overview]
Message-ID: <1317292461-12291-1-git-send-email-berrange@redhat.com> (raw)

From: "Daniel P. Berrange" <berrange@redhat.com>

The Linux guest kernel does not appear to have a problem handling
a mount_tag larger than 32 bytes. Increase the limit to 255 bytes,
though perhaps it can be made larger still, or not limited at all ?

Tested with a 3.0.4 kernel and a mount_tag 255 bytes in length.

* hw/9pfs/virtio-9p.h: Change MAX_TAG_LEN to 255

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 hw/9pfs/virtio-9p.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/9pfs/virtio-9p.h b/hw/9pfs/virtio-9p.h
index 17d44b4..b133b33 100644
--- a/hw/9pfs/virtio-9p.h
+++ b/hw/9pfs/virtio-9p.h
@@ -144,7 +144,7 @@ struct V9fsPDU
 /* The ID for virtio console */
 #define VIRTIO_ID_9P    9
 #define MAX_REQ         128
-#define MAX_TAG_LEN     32
+#define MAX_TAG_LEN     255
 
 #define BUG_ON(cond) assert(!(cond))
 
-- 
1.7.6.2

             reply	other threads:[~2011-09-29 10:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-29 10:34 Daniel P. Berrange [this message]
2011-09-29 14:53 ` [Qemu-devel] [PATCH] Raise 9pfs mount_tag limit from 32 to 255 bytes Aneesh Kumar K.V
2011-09-29 15:22   ` Daniel P. Berrange
2011-10-07  9:27     ` Daniel P. Berrange
2011-10-07 11:19       ` Aneesh Kumar K.V
2011-10-20 15:13         ` Daniel P. Berrange
2011-11-01 18:27           ` Anthony Liguori
2011-11-01 18:48             ` Daniel P. Berrange
2011-11-01 19:45               ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317292461-12291-1-git-send-email-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=harsh@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).